Bug 83521

Summary:

platform/graphics/skia/GlyphPageTreeNodeSkia.cpp mis-use 'continue' for 'break'

Product:

WebKit

Reporter:

Xiaomei Ji <xji>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
patch	none
patch	levin: review+
patch	levin: review+
patch	none

Xiaomei Ji

Reported 2012-04-09 16:14:23 PDT

In function GlyphPage::fill(), Line 103, "continue" should be changed to 'break".

Attachments
patch (1.27 KB, patch) 2012-04-11 10:28 PDT, Xiaomei Ji	no flags	Details Formatted Diff Diff
patch (1.32 KB, patch) 2012-04-11 10:49 PDT, Xiaomei Ji	no flags	Details Formatted Diff Diff
patch (1.31 KB, patch) 2012-04-11 23:51 PDT, Xiaomei Ji	levin: review+	Details Formatted Diff Diff
patch (1.63 KB, patch) 2012-04-16 14:02 PDT, Xiaomei Ji	levin: review+	Details Formatted Diff Diff
patch (1.60 KB, patch) 2012-04-16 15:26 PDT, Xiaomei Ji	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Xiaomei Ji

Comment 1 2012-04-11 10:28:03 PDT

Created attachment 136692 [details] patch

WebKit Review Bot

Comment 2 2012-04-11 10:30:55 PDT

Attachment 136692 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Xiaomei Ji

Comment 3 2012-04-11 10:49:14 PDT

Created attachment 136699 [details] patch

Xiaomei Ji

Comment 4 2012-04-11 23:51:38 PDT

Created attachment 136836 [details] patch

Xiaomei Ji

Comment 5 2012-04-16 14:02:18 PDT

Created attachment 137397 [details] patch

Xiaomei Ji

Comment 6 2012-04-16 15:26:48 PDT

Created attachment 137416 [details] patch sync and resolve conflict for ews and cq.