Bug 8352

Summary: CSS text-shadow does not repaint completely when changed
Product: WebKit Reporter: Dimitri Bouniol <dimitri008>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mitz
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
URL: http://homepage.mac.com/dimitri008/lilaPortal/new/index1.html
Attachments:
Description Flags
Example of bug
none
Change RenderStyle::diff() to return Layout when shadow changes hyatt: review+

Dimitri Bouniol
Reported 2006-04-12 21:00:42 PDT
The CSS property text-shadow applied to a .class:hover leaves some of the shadow on the view when the mouse exits the area. URL Note: drag the mouse along the right side bar from bottom to top over the links to see the bug.
Attachments
Example of bug (14.64 KB, image/png)
2006-04-12 21:05 PDT, Dimitri Bouniol 		no flags
Details
Change RenderStyle::diff() to return Layout when shadow changes (3.00 KB, patch)
2006-04-19 02:00 PDT, mitz 		hyatt: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Bouniol
Comment 1 2006-04-12 21:05:39 PDT
Created attachment 7665 [details] Example of bug Mouse is over the underlined link.
mitz
Comment 2 2006-04-13 04:25:11 PDT
The easy fix is to make RenderStyle::diff() return Layout for non-euqivalent text shadows. You can refine this to check if the shadows have different radii (defined as max (|offset| + blur)), so that hover effects that only change the shadow color will remain Repaint.
mitz
Comment 3 2006-04-19 02:00:26 PDT
Created attachment 7819 [details] Change RenderStyle::diff() to return Layout when shadow changes
Dave Hyatt
Comment 4 2006-04-19 11:57:05 PDT
Comment on attachment 7819 [details] Change RenderStyle::diff() to return Layout when shadow changes r=me
Timothy Hatcher
Comment 5 2006-04-19 19:30:05 PDT
Landed in r13981.
Note You need to log in before you can comment on or make changes to this bug.