Bug 83508
| Summary: | merge the functionality of test_expectations and Skipped files | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Pranke <dpranke> |
| Component: | Tools / Tests | Assignee: | Dirk Pranke <dpranke> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | Keywords: | NRWT |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Dirk Pranke
We should probably replace the functionality of test_expectations.txt and Skipped files with something that combines the best aspects of both ...
Advantages of test_expectations files:
- You can do finer-grained specifications of failures (IMAGE vs. TEXT vs. both)
- You can programmatically specify a bug # to associate with a failure
- You can specify different results for Release vs. Debug, other configurations
- You can specify failures for multiple different platforms in one place
Disadvantages of test_expectations files:
- Entries can stay in the file too long, making it hard to manage
- You can't easily stack failures on top of each other, if a test fails one way, then starts to fail differently
- It can be hard to separate out failures by platform
- The syntax is complicated
Advantages of Skipped files:
- Very simple to use
- Have a clean #include / inheritance / cascade mechanism
- Strong incentives to keep entries out of this file if they aren't needed
Disadvantages of Skipped files:
- Not very flexible
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Dirk Pranke
closing ... this is being tracked elsewhere.