Bug 83478

Summary:

Web Inspector: annotate front-end for newer closure compiler.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	yurys: review+, webkit.review.bot: commit-queue-
Archive of layout-test-results from ec2-cr-linux-01	none
Archive of layout-test-results from ec2-cr-linux-03	none

Pavel Feldman

Reported 2012-04-09 09:27:12 PDT

Patch to follow.

Attachments
Patch (21.93 KB, patch) 2012-04-09 09:32 PDT, Pavel Feldman	yurys: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cr-linux-01 (6.40 MB, application/zip) 2012-04-09 13:15 PDT, WebKit Review Bot	no flags	Details
Archive of layout-test-results from ec2-cr-linux-03 (6.20 MB, application/zip) 2012-04-09 14:08 PDT, WebKit Review Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2012-04-09 09:32:39 PDT

Created attachment 136238 [details] Patch

WebKit Review Bot

Comment 2 2012-04-09 13:15:42 PDT

Comment on attachment 136238 [details] Patch Attachment 136238 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12373319 New failing tests: inspector/extensions/extensions-eval.html

WebKit Review Bot

Comment 3 2012-04-09 13:15:48 PDT

Created attachment 136288 [details] Archive of layout-test-results from ec2-cr-linux-01 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

WebKit Review Bot

Comment 4 2012-04-09 14:08:22 PDT

Comment on attachment 136238 [details] Patch Attachment 136238 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12369345 New failing tests: inspector/extensions/extensions-eval.html

WebKit Review Bot

Comment 5 2012-04-09 14:08:28 PDT

Created attachment 136304 [details] Archive of layout-test-results from ec2-cr-linux-03 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Yury Semikhatsky

Comment 6 2012-04-10 00:35:21 PDT

Comment on attachment 136238 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136238&action=review > Source/WebCore/inspector/front-end/BreakpointManager.js:274 > * @param {Array.<DebuggerAgent.Location>} locations locations param is also be optional/nullable, isn't it? > Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:469 > + * @param {number=} fromIndex // must declare optional Could you provide more derailed comment or remove this one as it doesn't doesn't add much information? > Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:548 > + * @param {number=} fromIndex // must declare optional Same here.

Pavel Feldman

Comment 7 2012-04-10 04:27:16 PDT

Committed r113707: <http://trac.webkit.org/changeset/113707>

Note You need to log in before you can comment on or make changes to this bug.