Bug 83465

Summary:

Web Inspector: split nodes and edges array in heap profiler serialization.

Product:

WebKit

Reporter:

Alexei Filippov <alph>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Alexei Filippov

Reported 2012-04-09 05:32:30 PDT

Make frontend able to read a new serialization format where nodes and edges come in two separate arrays.

Attachments
Patch (5.50 KB, patch) 2012-04-09 05:35 PDT, Alexei Filippov	no flags	Details Formatted Diff Diff
Patch (9.67 KB, patch) 2012-04-09 10:23 PDT, Alexei Filippov	no flags	Details Formatted Diff Diff
Patch (16.87 KB, patch) 2012-04-10 07:15 PDT, Alexei Filippov	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Alexei Filippov

Comment 1 2012-04-09 05:35:04 PDT

Created attachment 136214 [details] Patch

Yury Semikhatsky

Comment 2 2012-04-09 06:16:11 PDT

Comment on attachment 136214 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136214&action=review Pleas add a test for the new snapshot format, r- for this. > Source/WebCore/inspector/front-end/HeapSnapshot.js:184 > + this._array.push(0); Can you move the meta node out of the array into its own element? > Source/WebCore/inspector/front-end/HeapSnapshot.js:222 > + // Add an extra node that points at the end of edges array. Can you do this is a separate change?

Alexei Filippov

Comment 3 2012-04-09 10:23:20 PDT

Created attachment 136259 [details] Patch

Yury Semikhatsky

Comment 4 2012-04-10 00:45:17 PDT

Comment on attachment 136259 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136259&action=review > Source/WebCore/inspector/front-end/HeapSnapshot.js:92 > + _parseIntArray: function() To be precise it is _parseUintArray

Alexei Filippov

Comment 5 2012-04-10 02:35:05 PDT

Comment on attachment 136214 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136214&action=review >> Source/WebCore/inspector/front-end/HeapSnapshot.js:184 >> + this._array.push(0); > > Can you move the meta node out of the array into its own element? This is for the original version. There has to be a zero dummy node. >> Source/WebCore/inspector/front-end/HeapSnapshot.js:222 >> + // Add an extra node that points at the end of edges array. > > Can you do this is a separate change? sure. removed.

Alexei Filippov

Comment 6 2012-04-10 02:35:30 PDT

Comment on attachment 136259 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136259&action=review >> Source/WebCore/inspector/front-end/HeapSnapshot.js:92 >> + _parseIntArray: function() > > To be precise it is _parseUintArray I promise to rename it when I'll be cleaning up the old serialization.

Alexei Filippov

Comment 7 2012-04-10 07:15:29 PDT

Created attachment 136450 [details] Patch

WebKit Review Bot

Comment 8 2012-04-10 14:45:51 PDT

Comment on attachment 136450 [details] Patch Clearing flags on attachment: 136450 Committed r113771: <http://trac.webkit.org/changeset/113771>

WebKit Review Bot

Comment 9 2012-04-10 14:45:57 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.