Bug 83456

Summary: [BlackBerry] Revert the changes that depend on Event changes, which is reverted already internally.
Product: WebKit Reporter: Charles Wei <charles.wei>
Component: UI EventsAssignee: Charles Wei <charles.wei>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, efidler, gmak, hausmann, leo.yang, manyoso, rwlbuis, staikos, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Patch
none
Patch none

Charles Wei
Reported 2012-04-08 23:38:45 PDT
BlackBerry porting enhances the Event by adding a member variable m_pluginHandled to indicate if the event is handled by the plugin. Need to upstream this change.
Attachments
Patch (3.97 KB, patch)
2012-04-08 23:46 PDT, Charles Wei 		no flags
DetailsFormatted DiffDiff
Patch (2.62 KB, patch)
2012-04-11 20:10 PDT, Charles Wei 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Charles Wei
Comment 1 2012-04-08 23:46:59 PDT
Created attachment 136189 [details] Patch
Alexey Proskuryakov
Comment 2 2012-04-09 10:25:56 PDT
Comment on attachment 136189 [details] Patch Even under PLATFORM(BLACKBERRY), this affects other ports by injecting a layering violation that will make future refactoring work more complicated. Core DOM should not know anything about plugins.
Charles Wei
Comment 3 2012-04-09 19:32:15 PDT
Looked into more detail of how BlackBerry porting uses this, I believe this should be removed, Will discuss internally in RIM first and will get back to this later. Possibly close this bug with resolution as "invalid".
Charles Wei
Comment 4 2012-04-10 21:28:35 PDT
An internal discussion and bug has been created , 148887, to remove this change to Event. If the internal change is approved and landed, we need to partially apply that change upstreaming, including the change to plugins/blackberry/PluginViewBlackBerry.cpp and page/EventHandler.cpp, to remove setPluginHandled() and pluginHandled() accordingly.
Charles Wei
Comment 5 2012-04-11 19:57:33 PDT
After internal discussion ,we decided that we won't need the change to Event, so we will revert our change to Event internally (which is already done with internal tracking 148887), and we will have this bug to revert the corresponding changes which has already been upstreamed. I will update the title of this PR accordingly.
Charles Wei
Comment 6 2012-04-11 20:10:54 PDT
Created attachment 136815 [details] Patch
WebKit Review Bot
Comment 7 2012-04-11 20:34:33 PDT
Comment on attachment 136815 [details] Patch Clearing flags on attachment: 136815 Committed r113939: <http://trac.webkit.org/changeset/113939>
WebKit Review Bot
Comment 8 2012-04-11 20:34:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.