Bug 83366 – Correct some LayoutUnit misuse in FilterEffectRenderer, RenderBlock, and RenderEmbeddedObject

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Levi Weintraub]

Description in changelog.

[Levi Weintraub]

Created attachment 136021 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 136021 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136021&action=review

> Source/WebCore/rendering/RenderBlock.cpp:7475
> -    return String::format("%p (%dx%d %dx%d)", floatingObject, floatingObject->x(), floatingObject->y(), floatingObject->maxX(), floatingObject->maxY());
> +    return String::format("%p (%dx%d %dx%d)", floatingObject, floatingObject->pixelSnappedX(), floatingObject->pixelSnappedY(), floatingObject->pixelSnappedMaxX(), floatingObject->pixelSnappedMaxY());

Huh?  Why does this method exist? :)

[WebKit Review Bot]

Comment on attachment 136021 [details]
Patch

Rejecting attachment 136021 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
queue/Source/WebKit/chromium/third_party/skia/include --revision 3543 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
42>At revision 3543.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/12362008

[Levi Weintraub]

Created attachment 136247 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 136247 [details]
Patch for landing

Clearing flags on attachment: 136247

Committed r113607: <http://trac.webkit.org/changeset/113607>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.