Bug 83366

Summary: Correct some LayoutUnit misuse in FilterEffectRenderer, RenderBlock, and RenderEmbeddedObject
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: eae, eric, jchaffraix, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Levi Weintraub 2012-04-06 07:16:29 PDT
Description in changelog.
Comment 1 Levi Weintraub 2012-04-06 07:27:06 PDT
Created attachment 136021 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-04-06 10:17:58 PDT
Comment on attachment 136021 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136021&action=review

> Source/WebCore/rendering/RenderBlock.cpp:7475
> -    return String::format("%p (%dx%d %dx%d)", floatingObject, floatingObject->x(), floatingObject->y(), floatingObject->maxX(), floatingObject->maxY());
> +    return String::format("%p (%dx%d %dx%d)", floatingObject, floatingObject->pixelSnappedX(), floatingObject->pixelSnappedY(), floatingObject->pixelSnappedMaxX(), floatingObject->pixelSnappedMaxY());

Huh?  Why does this method exist? :)
Comment 3 WebKit Review Bot 2012-04-06 12:33:03 PDT
Comment on attachment 136021 [details]
Patch

Rejecting attachment 136021 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
queue/Source/WebKit/chromium/third_party/skia/include --revision 3543 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
42>At revision 3543.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/12362008
Comment 4 Levi Weintraub 2012-04-09 10:01:59 PDT
Created attachment 136247 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-04-09 12:47:12 PDT
Comment on attachment 136247 [details]
Patch for landing

Clearing flags on attachment: 136247

Committed r113607: <http://trac.webkit.org/changeset/113607>
Comment 6 WebKit Review Bot 2012-04-09 12:47:17 PDT
All reviewed patches have been landed.  Closing bug.