Bug 83334

Summary: Provide Obj-C private API to simplify markup
Product: WebKit Reporter: Enrica Casucci <enrica>
Component: HTML EditingAssignee: Enrica Casucci <enrica>
Status: RESOLVED FIXED    
Severity: Normal CC: sam
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: Unspecified   
Attachments:
Description Flags
Patch
sam: review-
Patch2 sam: review+

Enrica Casucci
Reported 2012-04-05 17:09:20 PDT
We want to expose this functionality directly, without having to perform a copy/paste to sanitize the markup.
Attachments
Patch (14.71 KB, patch)
2012-04-05 17:14 PDT, Enrica Casucci 		sam: review-
DetailsFormatted DiffDiff
Patch2 (17.17 KB, patch)
2012-04-06 12:57 PDT, Enrica Casucci 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Enrica Casucci
Comment 1 2012-04-05 17:14:42 PDT
Created attachment 135942 [details] Patch
Sam Weinig
Comment 2 2012-04-06 10:43:47 PDT
Comment on attachment 135942 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135942&action=review > Tools/TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:72 > + We should test the different combinations this API allows, including non-nill endNode, endNode before startNode, and endNode in a different document than startNode. I guess if should also make sure that startNode is in a document in webView.
Enrica Casucci
Comment 3 2012-04-06 12:57:51 PDT
Created attachment 136055 [details] Patch2 Addresses comments.
Sam Weinig
Comment 4 2012-04-06 15:36:10 PDT
Comment on attachment 136055 [details] Patch2 View in context: https://bugs.webkit.org/attachment.cgi?id=136055&action=review > Source/WebCore/editing/Editor.cpp:1060 > + applyCommand(SimplifyMarkupCommand::create(m_frame->document(), startNode, (endNode) ? endNode->traverseNextNode(): 0)); Missing space before : > Tools/TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:111 > + > + > +} Unnecessary whitepace.
Enrica Casucci
Comment 5 2012-04-06 15:44:29 PDT
http://trac.webkit.org/changeset/113510
Note You need to log in before you can comment on or make changes to this bug.