Summary: | Provide Obj-C private API to simplify markup | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Enrica Casucci <enrica> | ||||||
Component: | HTML Editing | Assignee: | Enrica Casucci <enrica> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | sam | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Mac | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Enrica Casucci
2012-04-05 17:09:20 PDT
Created attachment 135942 [details]
Patch
Comment on attachment 135942 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135942&action=review > Tools/TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:72 > + We should test the different combinations this API allows, including non-nill endNode, endNode before startNode, and endNode in a different document than startNode. I guess if should also make sure that startNode is in a document in webView. Created attachment 136055 [details]
Patch2
Addresses comments.
Comment on attachment 136055 [details] Patch2 View in context: https://bugs.webkit.org/attachment.cgi?id=136055&action=review > Source/WebCore/editing/Editor.cpp:1060 > + applyCommand(SimplifyMarkupCommand::create(m_frame->document(), startNode, (endNode) ? endNode->traverseNextNode(): 0)); Missing space before : > Tools/TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:111 > + > + > +} Unnecessary whitepace. |