Bug 83307

Summary: Replace static_cast with jsCast when casting JSCell subclasses in JSC
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch barraclough: review+

Oliver Hunt
Reported 2012-04-05 13:03:50 PDT
Replace static_cast with jsCast when casting JSCell subclasses in JSC
Attachments
Patch (33.99 KB, patch)
2012-04-05 13:06 PDT, Oliver Hunt 		barraclough: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2012-04-05 13:06:13 PDT
Created attachment 135885 [details] Patch
WebKit Review Bot
Comment 2 2012-04-05 13:09:22 PDT
Attachment 135885 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/APICast.h', u'So..." exit_code: 1 Source/JavaScriptCore/jit/JITStubs.cpp:2961: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
Oliver Hunt
Comment 3 2012-04-05 13:11:00 PDT
Committed r113363: <http://trac.webkit.org/changeset/113363>
Note You need to log in before you can comment on or make changes to this bug.