Bug 83257

Summary:

Add notifications for frame loader deferring and resuming

Product:

WebKit

Reporter:

Leo Yang <leo.yang>

Component:

Page Loading

Assignee:

Leo Yang <leo.yang>

Status:

ASSIGNED ---

Severity:

Normal

CC:

abarth, ap, beidson, charles.wei, cmarcelo, dbates, eric, japhet, rwlbuis, staikos, tonikitoo, webkit.review.bot, zimmermann

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

73144

Attachments:

Description	Flags
Patch	none
Patch v2	abarth: review-
Patch v3	none

Description Leo Yang 2012-04-05 01:06:28 PDT

Some platforms (so far blackberry) are interested in notifications before a frame loader is deferred and after it is resumed.

Comment 1 Leo Yang 2012-04-05 01:52:05 PDT

Created attachment 135783 [details]
Patch

Comment 2 Antonio Gomes 2012-04-05 07:40:42 PDT

It looks good to me, but I will wait for some "FrameLoader guy" to say something. Btw, it would be nice to say a few words about the usage in the BlackBerry port.

Comment 3 Alexey Proskuryakov 2012-04-05 10:36:13 PDT

This looks quite redundant - deferring doesn't happen all by itself, the client already knows about conditions that cause it.

Comment 4 Leo Yang 2012-04-05 19:19:16 PDT

(In reply to comment #3)
> This looks quite redundant - deferring doesn't happen all by itself, the client already knows about conditions that cause it.

The caller does know the conditions that cause deferring and resuming but the notifications are not redundant. The notifications make caller's life easier, otherwise on every call sites the caller need to iterate the frame loaders for the page twice one for deferring and another one for resuming.

Comment 5 Leo Yang 2012-04-05 20:05:00 PDT

Created attachment 135971 [details]
Patch v2

Adding explain that the notifications are used for the blackberry porting.

Comment 6 Alexey Proskuryakov 2012-04-05 20:51:38 PDT

This change still doesn't make sense to me. Load deferring is an implementation detail of WebCore, clients needn't know about it.

Comment 7 Leo Yang 2012-04-05 21:02:08 PDT

(In reply to comment #6)
> This change still doesn't make sense to me. Load deferring is an implementation detail of WebCore, clients needn't know about it.

Do you think page load is an implementation detail of WebCore? Is it FrameLoaderClient::dispatchDidCommitLoad() necessary for example?

Comment 8 Adam Barth 2012-04-06 11:10:48 PDT

Comment on attachment 135971 [details]
Patch v2

I'm not sure it makes sense to notify the client here.  Can you explain more about how you're using this notification?

Comment 9 Leo Yang 2012-04-09 18:53:42 PDT

Created attachment 136369 [details]
Patch v3

Adding more explaining.

Comment 10 Anders Carlsson 2014-02-05 10:52:45 PST

Comment on attachment 136369 [details]
Patch v3

Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.