Bug 83240 – Provide a separate editing command to cleanup of redundant markup

• Component: HTML Editing
• Status: RESOLVED FIXED

[Enrica Casucci]

The markup cleanup is currently implemented as part of the ReplaceSelection command.
We want to move it into a separate command so that it can be performed independently from ReplaceSelection.

[Enrica Casucci]

Created attachment 135738 [details]
Patch

[Philippe Normand]

Comment on attachment 135738 [details]
Patch

Attachment 135738 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12338039

[Build Bot]

Comment on attachment 135738 [details]
Patch

Attachment 135738 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12336064

[Build Bot]

Comment on attachment 135738 [details]
Patch

Attachment 135738 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12337071

[WebKit Review Bot]

Comment on attachment 135738 [details]
Patch

Attachment 135738 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12337078

[Enrica Casucci]

Created attachment 135745 [details]
Patch2

Attempting to fix build issues.

[Philippe Normand]

Comment on attachment 135745 [details]
Patch2

Attachment 135745 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12335085

[Ryosuke Niwa]

Comment on attachment 135745 [details]
Patch2

View in context: https://bugs.webkit.org/attachment.cgi?id=135745&action=review

Please fix the gtk build before you land. Also, you probably need to modify EditorAllInOne.cpp for Windows.

> Source/WebCore/editing/ReplaceSelectionCommand.cpp:1023
> -        removeRedundantMarkup(insertedNodes);
> +        applyCommandToComposite(SimplifyMarkupCommand::create(document(), insertedNodes.firstNodeInserted(), insertedNodes.pastLastLeaf()));

You should add simplifyMarkup() to CompositeEditCommand.

> Source/WebCore/editing/SimplifyMarkupCommand.cpp:2
> + * Copyright (C) 2005, 2006 Apple Computer, Inc.  All rights reserved.

Maybe you should add 2011 here?

[Enrica Casucci]

(In reply to comment #8)
> (From update of attachment 135745 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=135745&action=review
> 
> Please fix the gtk build before you land.
I don't believe I broke it. The message is obscure.
I'll post another patch and watch the bots to make sure.

 Also, you probably need to modify EditorAllInOne.cpp for Windows.
Ok
> 
> You should add simplifyMarkup() to CompositeEditCommand.
I can do that in a later patch.
> 
> > Source/WebCore/editing/SimplifyMarkupCommand.cpp:2
> > + * Copyright (C) 2005, 2006 Apple Computer, Inc.  All rights reserved.
> 
> Maybe you should add 2011 here?
Actually 2012! Good catch.

[Enrica Casucci]

Created attachment 135863 [details]
Patch to check builds

[Enrica Casucci]

Created attachment 135865 [details]
One more

[Enrica Casucci]

Created attachment 135886 [details]
Resolved conflict

[Enrica Casucci]

http://trac.webkit.org/changeset/113369