Summary: | [chromium] Make culling work with clipped rects | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Shawn Singh <shawnsingh> | ||||||
Component: | Layout and Rendering | Assignee: | Dana Jansens <danakj> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | backer, cc-bugs, danakj, enne, jamesr, piman, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 80806, 83487, 83494 | ||||||||
Bug Blocks: | 83351 | ||||||||
Attachments: |
|
Description
Shawn Singh
2012-04-04 14:27:24 PDT
Created attachment 135867 [details]
Patch
Comment on attachment 135867 [details]
Patch
Sorry, the first patch has some build errors on some of the bots, have to fix that first. But if this is the fix, it can still be reviewed. When this is ready to land, I'd still prefer it its OK, that we wait for a day between when the previous one lands and this one?
That's fine. Comment on attachment 135867 [details]
Patch
OK, the fixed previous patch is landed now, removing cq-
This patch unofficially LGTM =)
Comment on attachment 135867 [details]
Patch
This isn't the whole set of changes needed.
>
> This patch unofficially LGTM =)
officially need to take foot out of mouth.
This fixes the http://www.apple.com/html5/showcase/vr/ page, and should be backported to M19. Created attachment 136079 [details]
Patch
Comment on attachment 136079 [details]
Patch
R=me. Looks great.
Comment on attachment 136079 [details] Patch Clearing flags on attachment: 136079 Committed r113561: <http://trac.webkit.org/changeset/113561> All reviewed patches have been landed. Closing bug. |