Bug 83154

Summary: Correct LayoutUnit usage in style functions adjustRectForShadow and getRoundedBorderFor
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Levi Weintraub <leviw>
Severity: Normal CC: eae, eric, jchaffraix, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60318    
Description Flags
Patch for landing none

Description Levi Weintraub 2012-04-04 06:15:18 PDT
adjustRectForShadow needs to adjust a LayoutRect since it's used to adjust repaint rects and such, while getRoundedBorderFor returns a pixel snapped RoundedRect.
Comment 1 Levi Weintraub 2012-04-04 06:28:38 PDT
Created attachment 135578 [details]
Comment 2 Levi Weintraub 2012-04-06 10:14:02 PDT
Comment on attachment 135578 [details]

Comment 3 WebKit Review Bot 2012-04-06 10:30:41 PDT
Comment on attachment 135578 [details]

Rejecting attachment 135578 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Hunk #1 FAILED at 68.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/style/ShadowData.cpp.rej
patching file Source/WebCore/rendering/style/ShadowData.h
Hunk #1 FAILED at 79.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/style/ShadowData.h.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Julien Cha..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12264970
Comment 4 Levi Weintraub 2012-04-09 09:56:26 PDT
Created attachment 136244 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-04-09 11:10:17 PDT
Comment on attachment 136244 [details]
Patch for landing

Clearing flags on attachment: 136244

Committed r113594: <http://trac.webkit.org/changeset/113594>
Comment 6 WebKit Review Bot 2012-04-09 11:10:22 PDT
All reviewed patches have been landed.  Closing bug.