Bug 83154

Summary: Correct LayoutUnit usage in style functions adjustRectForShadow and getRoundedBorderFor
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: eae, eric, jchaffraix, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch
none
Patch for landing none

Levi Weintraub
Reported 2012-04-04 06:15:18 PDT
adjustRectForShadow needs to adjust a LayoutRect since it's used to adjust repaint rects and such, while getRoundedBorderFor returns a pixel snapped RoundedRect.
Attachments
Patch (4.31 KB, patch)
2012-04-04 06:28 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.69 KB, patch)
2012-04-09 09:56 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2012-04-04 06:28:38 PDT
Created attachment 135578 [details] Patch
Levi Weintraub
Comment 2 2012-04-06 10:14:02 PDT
Comment on attachment 135578 [details] Patch Thanks!
WebKit Review Bot
Comment 3 2012-04-06 10:30:41 PDT
Comment on attachment 135578 [details] Patch Rejecting attachment 135578 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Core/rendering/style/ShadowData.cpp Hunk #1 FAILED at 68. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/style/ShadowData.cpp.rej patching file Source/WebCore/rendering/style/ShadowData.h Hunk #1 FAILED at 79. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/style/ShadowData.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Julien Cha..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12264970
Levi Weintraub
Comment 4 2012-04-09 09:56:26 PDT
Created attachment 136244 [details] Patch for landing
WebKit Review Bot
Comment 5 2012-04-09 11:10:17 PDT
Comment on attachment 136244 [details] Patch for landing Clearing flags on attachment: 136244 Committed r113594: <http://trac.webkit.org/changeset/113594>
WebKit Review Bot
Comment 6 2012-04-09 11:10:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.