Call histogramEnumeration directly

• Component: New Bugs
• Status: RESOLVED FIXED

[Mark Pilgrim (Google)]

Call histogramEnumeration directly

[Mark Pilgrim (Google)]

Created attachment 135488 [details]
Patch

[Mark Pilgrim (Google)]

Fails to compile WebCore/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp, can not find <public/Platform.h>

[WebKit Review Bot]

Comment on attachment 135488 [details]
Patch

Attachment 135488 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12325463

[Adam Barth]

Comment on attachment 135488 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135488&action=review

> Source/WebCore/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:128
> -        PlatformSupport::histogramEnumeration(name, sample, boundaryValue);
> +        WebKit::Platform::current()->histogramEnumeration(name, sample, boundaryValue);

This should use histogramEnumeration from HistogramSupport.h (because this file is outside the platform directory).

> Source/WebCore/platform/chromium/PlatformSupport.h:-265
> -    static void histogramEnumeration(const char* name, int sample, int boundaryValue);

Please remove the implementation of this function in PlatformSupport.cpp.

[Mark Pilgrim (Google)]

Created attachment 135587 [details]
Patch

[Mark Pilgrim (Google)]

(In reply to comment #4)
> (From update of attachment 135488 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=135488&action=review
> 
> > Source/WebCore/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:128
> > -        PlatformSupport::histogramEnumeration(name, sample, boundaryValue);
> > +        WebKit::Platform::current()->histogramEnumeration(name, sample, boundaryValue);
> 
> This should use histogramEnumeration from HistogramSupport.h (because this file is outside the platform directory).

Done.

> 
> > Source/WebCore/platform/chromium/PlatformSupport.h:-265
> > -    static void histogramEnumeration(const char* name, int sample, int boundaryValue);
> 
> Please remove the implementation of this function in PlatformSupport.cpp.

Done.

[Adam Barth]

Comment on attachment 135587 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135587&action=review

> Source/WebCore/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:37
> +#if !PLATFORM(QT)
> +#include "HistogramSupport.h"
> +#endif

This should be included unconditionally.

[Adam Barth]

Comment on attachment 135587 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135587&action=review

> Source/WebCore/ChangeLog:7
> +        Call histogramEnumeration directly
> +        https://bugs.webkit.org/show_bug.cgi?id=83106
> +
> +        Reviewed by NOBODY (OOPS!).
> +

It would also be good to have some text in the ChangeLog referencing either the meta bug or the webkit-dev post.  It's fine to say that this change is part of a series of patches to XYZ.  You just want someone who starts with this patch to have a breadcrumb trail back to understanding what's going on.

[Mark Pilgrim (Google)]

Created attachment 135687 [details]
Patch

[Mark Pilgrim (Google)]

(In reply to comment #7)
> (From update of attachment 135587 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=135587&action=review
> 
> > Source/WebCore/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:37
> > +#if !PLATFORM(QT)
> > +#include "HistogramSupport.h"
> > +#endif
> 
> This should be included unconditionally.

Done.

[Mark Pilgrim (Google)]

(In reply to comment #8)
> (From update of attachment 135587 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=135587&action=review
> 
> > Source/WebCore/ChangeLog:7
> > +        Call histogramEnumeration directly
> > +        https://bugs.webkit.org/show_bug.cgi?id=83106
> > +
> > +        Reviewed by NOBODY (OOPS!).
> > +
> 
> It would also be good to have some text in the ChangeLog referencing either the meta bug or the webkit-dev post.  It's fine to say that this change is part of a series of patches to XYZ.  You just want someone who starts with this patch to have a breadcrumb trail back to understanding what's going on.

Done.

[Adam Barth]

Comment on attachment 135687 [details]
Patch

Thanks!

[WebKit Review Bot]

Comment on attachment 135687 [details]
Patch

Clearing flags on attachment: 135687

Committed r113255: <http://trac.webkit.org/changeset/113255>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.