Summary: | apple.com top navigation bar appears inside video during full screen exit animation | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||||||||||
Component: | Media | Assignee: | Jer Noble <jer.noble> | ||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||
Severity: | Normal | CC: | dglazkov, gustavo, tkent, webkit.review.bot, xan.lopez | ||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||
URL: | http://www.apple.com/education/#video-textbooks | ||||||||||||||||||
Attachments: |
|
Description
Jer Noble
2012-04-03 16:55:51 PDT
Created attachment 135657 [details]
Patch
Created attachment 135661 [details]
Patch
Rebaselined patch against ToT.
Created attachment 135669 [details]
Patch
Rebaselined again; this time it'll stick.
Comment on attachment 135669 [details] Patch Attachment 135669 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12329072 Comment on attachment 135669 [details] Patch Attachment 135669 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12328096 Created attachment 136088 [details]
Patch
Created attachment 136092 [details]
Patch
Added hasCustomFullScreenBehavior accessor to the Chromium version of LayoutTestController.
Comment on attachment 136092 [details] Patch Attachment 136092 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12360155 Created attachment 136113 [details]
Patch
Fix the GTK build by re-exporting the necessary symbols.
Comment on attachment 136113 [details] Patch Attachment 136113 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12363183 Comment on attachment 136113 [details] Patch Attachment 136113 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12363263 Created attachment 136245 [details]
Patch
Fixed up the GTK and Chromium port parts of the patch.
Comment on attachment 136245 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136245&action=review > Source/WebCore/ChangeLog:22 > + * dom/Document.cpp: > + (WebCore::Document::webkitWillExitFullScreenForElement): > + (WebCore::Document::webkitDidExitFullScreenForElement): > + > + To facilitate writing reproducible LayoutTests, expose webkitWill/Did/Enter/ExitFullScreen > + from the Internals object, so scripts can call them explicitly: > + * testing/Internals.cpp: > + (WebCore::Internals::webkitWillEnterFullScreenForElement): > + (WebCore::Internals::webkitDidEnterFullScreenForElement): > + (WebCore::Internals::webkitWillExitFullScreenForElement): > + (WebCore::Internals::webkitDidExitFullScreenForElement): Nit: having comments about what changed in each function would have made this much easier for someone that doesn't know so much about fullscreen (me) review this. > Source/WebCore/dom/Document.cpp:-5448 > - if (!attached() || inPageCache()) > - return; Nit: please add a comment about why this is no longer necessary to the ChangLog. > Source/WebCore/dom/Document.cpp:-5457 > - if (!attached() || inPageCache()) Ditto. > LayoutTests/fullscreen/full-screen-exit-animation-stacking-context.html:7 > + function init() { Nit: Function opening brace on its own line please. Here and throughout the file. Committed r114790: <http://trac.webkit.org/changeset/114790> |