Bug 83086

Summary: auto margins on flexbox should allocate space in the flex direction
Product: WebKit Reporter: Tony Chang <tony>
Component: Layout and RenderingAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 62048    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch none

Tony Chang
Reported 2012-04-03 15:58:52 PDT
See the section here: http://dev.w3.org/csswg/css3-flexbox/#auto-margins We're currently treating auto margins as 0.
Attachments
Patch (21.73 KB, patch)
2012-05-18 16:07 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch for landing (22.50 KB, patch)
2012-05-21 15:43 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch (28.49 KB, patch)
2012-05-23 14:03 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2012-05-18 16:07:16 PDT
Created attachment 142812 [details] Patch
Ojan Vafai
Comment 2 2012-05-21 15:34:08 PDT
Comment on attachment 142812 [details] Patch Code looks good. There's a comment at the end of RenderFlexibleBox::computeMainAxisPreferredSizes that you need to update to be a bit more accurate.
Tony Chang
Comment 3 2012-05-21 15:43:23 PDT
Created attachment 143116 [details] Patch for landing
WebKit Review Bot
Comment 4 2012-05-21 21:07:56 PDT
Comment on attachment 143116 [details] Patch for landing Clearing flags on attachment: 143116 Committed r117897: <http://trac.webkit.org/changeset/117897>
WebKit Review Bot
Comment 5 2012-05-21 21:08:01 PDT
All reviewed patches have been landed. Closing bug.
Tony Chang
Comment 6 2012-05-23 14:03:50 PDT
Reopening to attach new patch.
Tony Chang
Comment 7 2012-05-23 14:03:52 PDT
Created attachment 143645 [details] Patch
Tony Chang
Comment 8 2012-05-23 14:05:51 PDT
Comment on attachment 143645 [details] Patch Wrong bug.
Note You need to log in before you can comment on or make changes to this bug.