Bug 83080 – Foreground of apple.com/iphone video page visible during full screen animation.

• Component: New Bugs
• Status: RESOLVED FIXED

[Jer Noble]

Foreground of apple.com/iphone video page visible during full screen animation.

[Jer Noble]

Created attachment 135440 [details]
Patch

[Jer Noble]

<rdar://problem/11178906>

[WebKit Review Bot]

Comment on attachment 135440 [details]
Patch

Attachment 135440 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12297088

New failing tests:
fullscreen/full-screen-stacking-context.html

[WebKit Review Bot]

Created attachment 135452 [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Jer Noble]

Created attachment 135456 [details]
Patch

Returned the <div> to a <video>.  didn't realize other ports were relying on the presence of a controller in this test.  Rebaseline'd the mac/ port test results to include the controller.

[Simon Fraser (smfr)]

Comment on attachment 135456 [details]
Patch

Here we go whack-a-moling. You should look at CSSStyleSelector::adjustRenderStyle() for the other ones you need, specifically:

    if (style->hasAutoZIndex() && ((e && e->document()->documentElement() == e) || style->opacity() < 1.0f
        || style->hasTransformRelatedProperty() || style->hasMask() || style->boxReflect() || style->hasFilter()

    bool hasTransformRelatedProperty() const { return hasTransform() || preserves3D() || hasPerspective(); }

[Darin Adler]

Are we going to keep updating this .css file every time we implement a new CSS attribute?

[Jer Noble]

(In reply to comment #7)
> Are we going to keep updating this .css file every time we implement a new CSS attribute?

No, the full screen and <dialog> spec will be updated so that fullscreen (and <dialog>) elements will exist in a separate stacking context, outside of CSS.  So this is just a solution until that spec is written and implemented.  At which point, no amount of stacking-context-creating CSS attributes can affect the full screen stacking context.

[Jer Noble]

(In reply to comment #6)
> (From update of attachment 135456 [details])
> Here we go whack-a-moling. You should look at CSSStyleSelector::adjustRenderStyle() for the other ones you need, specifically:
> 
>     if (style->hasAutoZIndex() && ((e && e->document()->documentElement() == e) || style->opacity() < 1.0f
>         || style->hasTransformRelatedProperty() || style->hasMask() || style->boxReflect() || style->hasFilter()
> 
>     bool hasTransformRelatedProperty() const { return hasTransform() || preserves3D() || hasPerspective(); }

I'll add ones for box-reflect, preserves3d, and hasPerspective.  Thanks!

[Jer Noble]

Committed r113498: <http://trac.webkit.org/changeset/113498>