Bug 82996 – Chromium testers should extract builds instead of building on their own

• Component: New Bugs
• Status: RESOLVED FIXED

[Ryosuke Niwa]

Chromium testers should extract builds instead of building on their own

[Ryosuke Niwa]

Created attachment 135262 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 135262 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135262&action=review

> Tools/BuildSlaveSupport/download-built-product:39
> +    parser.add_option("--platform", dest="platform")
> +    parser.add_option("--debug", action="store_const", const="debug", dest="configuration")
> +    parser.add_option("--release", action="store_const", const="release", dest="configuration")

Note that platform and configuration are not used at the moment. They're here for the forward compatibility.

[Tony Chang]

Comment on attachment 135262 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135262&action=review

> Tools/BuildSlaveSupport/built-product-archive:219
> +    elif platform == 'chromium':
> +        removeDirectoryIfExists(configurationBuildDirectory)
> +        os.makedirs(configurationBuildDirectory)
> +        return unzipArchive(configurationBuildDirectory, configuration)

This is the same as the qt, gtk, efl branch.  Can we merge them?  Would also be nice to do the removeDir/makedirs before the if.

[Ryosuke Niwa]

Thanks for the review.

(In reply to comment #3)
> This is the same as the qt, gtk, efl branch.  Can we merge them?  Would also be nice to do the removeDir/makedirs before the if.

Will do.

[Ryosuke Niwa]

Committed r113067: <http://trac.webkit.org/changeset/113067>

[Csaba Osztrogonác]

Reopen, because it broke our Qt ARM tester bot on http://build.webkit.sed.hu

http://build.webkit.sed.hu/builders/ARMv5%20Linux%20Qt%20Release%20%28Test%29/builds/6274

It's too late for me now, but I can check it tomorrow what happened.

[Ryosuke Niwa]

(In reply to comment #6)
> Reopen, because it broke our Qt ARM tester bot on http://build.webkit.sed.hu
> 
> http://build.webkit.sed.hu/builders/ARMv5%20Linux%20Qt%20Release%20%28Test%29/builds/6274
> 
> It's too late for me now, but I can check it tomorrow what happened.

Yeah, addressing Tony's comment (calling removeDirectoryIfExists outside if) resulted in some bug :(  It should be fixed in http://trac.webkit.org/changeset/113071.

[Csaba Osztrogonác]

(In reply to comment #7)
> Yeah, addressing Tony's comment (calling removeDirectoryIfExists outside if) resulted in some bug :(  It should be fixed in http://trac.webkit.org/changeset/113071.

Unfortunately it didn't fix.

Traceback (most recent call last):
  File "./Tools/BuildSlaveSupport/built-product-archive", line 218, in <module>
    sys.exit(main())
  File "./Tools/BuildSlaveSupport/built-product-archive", line 61, in main
    return extractBuiltProduct(options.configuration, options.platform)
  File "./Tools/BuildSlaveSupport/built-product-archive", line 213, in extractBuiltProduct
    os.makedirs(configurationBuildDirectory)
  File "/usr/lib/python2.6/os.py", line 157, in makedirs
    mkdir(name, mode)
OSError: [Errno 17] File exists: '/home/webkitbuildbot/slaves/armReleaseTest/buildslave/arm-qt-linux-release-arm-test/build/WebKitBuild/Release'

[Csaba Osztrogonác]

Oh, I think I should modify our master.cfg too after this change - http://trac.webkit.org/changeset/113067/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg

[Ryosuke Niwa]

(In reply to comment #9)
> Oh, I think I should modify our master.cfg too after this change - http://trac.webkit.org/changeset/113067/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg

Ah, yes. You may need to adjust your master.cfg if you're using WebKIt's BuildSlaveSupport scripts.

[Csaba Osztrogonác]

I fixed our master.cfg and it works now.

[Ryosuke Niwa]

Build fixes:
http://trac.webkit.org/changeset/113071
http://trac.webkit.org/changeset/113072
http://trac.webkit.org/changeset/113074
http://trac.webkit.org/changeset/113077
http://trac.webkit.org/changeset/113079
http://trac.webkit.org/changeset/113094

[Ryosuke Niwa]

More build fixes:
http://trac.webkit.org/changeset/113115
http://trac.webkit.org/changeset/113124
http://trac.webkit.org/changeset/113128
http://trac.webkit.org/changeset/113134
http://trac.webkit.org/changeset/113144