Summary: | run-webkit-tests with a relative --root causes tests to fail because DYLD_LIBRARY_PATH is not set | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||
Component: | Tools / Tests | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, dpranke, eric, mrowe, ojan, simon.fraser, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2012-04-02 16:00:30 PDT
Created attachment 135216 [details]
Patch
Comment on attachment 135216 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135216&action=review > Tools/Scripts/webkitpy/layout_tests/port/webkit.py:378 > + return self._filesystem.join(os.getcwd(), build_directory, *comps) This is fine but I'd probably do: return self._filesystem.join(self.abspath(build_directory), *comps) instead; that captures the intent a little more clearly (IMO, of course). (In reply to comment #2) > (From update of attachment 135216 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=135216&action=review > > > Tools/Scripts/webkitpy/layout_tests/port/webkit.py:378 > > + return self._filesystem.join(os.getcwd(), build_directory, *comps) > > This is fine but I'd probably do: > > return self._filesystem.join(self.abspath(build_directory), *comps) > > instead; that captures the intent a little more clearly (IMO, of course). Sorry, that should've been: self._filesystem.join(self._filesystem.abspath(build_directory), *comps) Comment on attachment 135216 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135216&action=review >>> Tools/Scripts/webkitpy/layout_tests/port/webkit.py:378 >>> + return self._filesystem.join(os.getcwd(), build_directory, *comps) >> >> This is fine but I'd probably do: >> >> return self._filesystem.join(self.abspath(build_directory), *comps) >> >> instead; that captures the intent a little more clearly (IMO, of course). > > Sorry, that should've been: > > self._filesystem.join(self._filesystem.abspath(build_directory), *comps) You want self._filessystem.getcwd() any place you'd use os.getcwd(). :) Comment on attachment 135216 [details]
Patch
r- for the use of os. Discussing on IRC now. :)
Created attachment 135236 [details]
Patch
Created attachment 135245 [details]
Patch
It'd make a heck of a lot more sense to fix that existing issue in a separate patch. It makes it a lot harder to see what in this patch fixes the described issue. Comment on attachment 135245 [details] Patch Clearing flags on attachment: 135245 Committed r112981: <http://trac.webkit.org/changeset/112981> All reviewed patches have been landed. Closing bug. |