Bug 8295

Summary: Dictionary pop-up panel targets the wrong word in a scrolled IFRAME
Product: WebKit Reporter: mitz
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: VERIFIED FIXED    
Severity: Normal CC: ap
Priority: P2 Keywords: Regression
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Test case
none
Patch, including manual test none

mitz
Reported 2006-04-10 08:33:49 PDT
Summary: When invoking the Dictionary pop-up panel on a word inside an IFRAME that is scrolled, the pop-up panel is invoked instead on a different word in the frame (the point targeted is offset from the mouse pointer by the scroll offset of the frame). Steps to reproduce: 1) Open the attached test case 2) Click the inner frame's down scroll arrow once 3) Move the mouse pointer over "laoreet" inside the inner frame 4) Press Command-Control-D Expected result: The Dictionary pop-up panel should appear over "laoreet". Actual result: The pop-up panel appears over "vehicula".
Attachments
Test case (1.02 KB, text/html)
2006-04-10 08:35 PDT, mitz 		no flags
Details
Patch, including manual test (3.95 KB, patch)
2006-04-10 09:06 PDT, mitz 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2006-04-10 08:35:28 PDT
Created attachment 7618 [details] Test case I am going to attach a patch
Alexey Proskuryakov
Comment 2 2006-04-10 08:50:22 PDT
As many editing/accessibility bugs, this has now become a native text field regression, marking as such.
mitz
Comment 3 2006-04-10 09:06:03 PDT
Created attachment 7619 [details] Patch, including manual test
mitz
Comment 4 2006-04-10 09:14:05 PDT
I think there is a similar problem in -[WebCoreFrameBridge _visiblePositionForPoint] (the final coordinates passed to positionForCoordinates() are wrong). I will try to come up with a test case for that.
Eric Seidel (no email)
Comment 5 2006-04-10 09:31:23 PDT
Comment on attachment 7619 [details] Patch, including manual test Looks great. r=me.
Note You need to log in before you can comment on or make changes to this bug.