Bug 82891

Summary: Web Inspector: Implement frontend for device metrics emulation
Product: WebKit Reporter: Alexander Pavlov (apavlov) <apavlov>
Component: Web Inspector (Deprecated)Assignee: Alexander Pavlov (apavlov) <apavlov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 75963    
Attachments:
Description Flags
Patch
none
Patch pfeldman: review+

Alexander Pavlov (apavlov)
Reported 2012-04-02 05:27:30 PDT
Patch to follow.
Attachments
Patch (22.81 KB, patch)
2012-04-02 06:56 PDT, Alexander Pavlov (apavlov) 		no flags
DetailsFormatted DiffDiff
Patch (30.56 KB, patch)
2012-04-02 07:21 PDT, Alexander Pavlov (apavlov) 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexander Pavlov (apavlov)
Comment 1 2012-04-02 06:56:34 PDT
Created attachment 135089 [details] Patch
WebKit Review Bot
Comment 2 2012-04-02 07:16:07 PDT
Comment on attachment 135089 [details] Patch Attachment 135089 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12308590
Alexander Pavlov (apavlov)
Comment 3 2012-04-02 07:21:23 PDT
Created attachment 135092 [details] Patch
Pavel Feldman
Comment 4 2012-04-02 07:27:59 PDT
Comment on attachment 135092 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135092&action=review > Source/WebCore/ChangeLog:48 > +2012-04-02 Alexander Pavlov <apavlov@chromium.org> Please remove this. > Source/WebCore/inspector/front-end/SettingsScreen.js:433 > + if (metrics && metrics.isValid && metrics.width && metrics.height) You are using isValid as a getter, while it is a function. Side-note: could you annotate device metrics class? > Source/WebCore/inspector/front-end/UserAgentSupport.js:57 > +WebInspector.UserAgentSupport.DeviceMetrics.parseFromSettings = function(value) parseSetting > Source/WebCore/inspector/front-end/UserAgentSupport.js:70 > +WebInspector.UserAgentSupport.DeviceMetrics.parseFromUserInput = function(widthString, heightString, fontScaleFactorString) parseUserInput
Alexander Pavlov (apavlov)
Comment 5 2012-04-02 07:45:45 PDT
Committed r112884: <http://trac.webkit.org/changeset/112884>
Note You need to log in before you can comment on or make changes to this bug.