Bug 82878
| Summary: | Remove custom binding for the types attribute in the DOM Clipboard class | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Vineet Chaudhary (vineetc) <code.vineet> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | abarth, darin, dcheng, haraken, syoichi |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 82888 | ||
| Bug Blocks: | |||
Vineet Chaudhary (vineetc)
Remove custom bindings for attribute type Array from Clipboard.idl.
Replace readonly attribute [CustomGetter] Array types;
To readonly attribute sequence<String> types;
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Vineet Chaudhary (vineetc)
As part of removing custom bindings of types Array Clipboard.idl also needs to have modified to have sequence<String>.
But according to current implementation of the Clipboard::types() it returns HashSet<String>.
In order to remove the custom bindings it should of type Vector<String>.
To resolve this we have two options.
1) Modify JSDombindings.h/V8Bindings.h to support HashSet.
2) Modify return type of types() to Vector.
IMO we should go with 2nd option if there are no objections.
Please let me know If you have any suggestions/thoughts on this.
Kentaro Hara
(In reply to comment #1)
> To resolve this we have two options.
> 1) Modify JSDombindings.h/V8Bindings.h to support HashSet.
> 2) Modify return type of types() to Vector.
>
> IMO we should go with 2nd option if there are no objections.
Agreed on the 2nd option.