Bug 82859

Summary: Missing NULL check for vendor string from glGetString()
Product: WebKit Reporter: Srikumar B <srikumar.b>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: haraken, srikumar.b, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Attachments:
Description Flags
proposed patch none

Srikumar B
Reported 2012-04-02 00:03:28 PDT
glGetString(GL_VENDOR) is possible to return NULL value but in Webkit we are not validating the return value before we call strstr() to compare the vendor list. Hence webkit crashes when it does not get vendor string response from openGL call glGetString(GL_VENDOR). Refer to http://www.opengl.org/sdk/docs/man/xhtml/glGetString.xml for glGetString() description.
Attachments
proposed patch (2.04 KB, patch)
2012-04-02 09:02 PDT, Srikumar B 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Srikumar B
Comment 1 2012-04-02 00:27:24 PDT
Please assign it to me. I will be uploading the patch with the changes.
Srikumar B
Comment 2 2012-04-02 09:02:07 PDT
Created attachment 135112 [details] proposed patch Proposed patch. Changes to add additional check for vendor string.
Kentaro Hara
Comment 3 2012-04-02 09:42:58 PDT
Comment on attachment 135112 [details] proposed patch Looks OK.
WebKit Review Bot
Comment 4 2012-04-02 10:32:33 PDT
Comment on attachment 135112 [details] proposed patch Clearing flags on attachment: 135112 Committed r112901: <http://trac.webkit.org/changeset/112901>
WebKit Review Bot
Comment 5 2012-04-02 10:32:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.