Bug 8284

Summary: prevent unnecessary entries in the "nodes with extra refs" hash table
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: JavaScriptCoreAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Fix eric: review+

Geoffrey Garen
Reported 2006-04-09 21:48:05 PDT
There's a unique cost to incrementing a node's ref count past one. If we use RefPtr::release instead of regular assignment, we can't keep the ref count at 1, and never pay the cost.
Attachments
Fix (6.09 KB, patch)
2006-04-09 21:49 PDT, Geoffrey Garen 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2006-04-09 21:49:55 PDT
Created attachment 7609 [details] Fix
Geoffrey Garen
Comment 2 2006-04-09 21:50:28 PDT
s/can't/can/ in the original description
Eric Seidel (no email)
Comment 3 2006-04-09 21:51:48 PDT
Comment on attachment 7609 [details] Fix Looks great. r=me.
Geoffrey Garen
Comment 4 2006-04-09 22:02:55 PDT
Landed.
Note You need to log in before you can comment on or make changes to this bug.