Bug 82839 – Generate the flakiness dashboard's list of webkit.org builders from the buildbot JSON

• Component: New Bugs
• Status: RESOLVED FIXED

[Ojan Vafai]

Generate the flakiness dashboard's list of webkit.org builders from the buildbot JSON

[Ojan Vafai]

Created attachment 134980 [details]
Patch

[Adam Barth]

Comment on attachment 134980 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134980&action=review

> Tools/TestResultServer/static-dashboards/builders.js:157
> +xhr.onreadystatechange = function() {
> +    if (xhr.readyState == 4) {

Why not just xhr.onload?

> Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:319
> -var PLATFORMS = ['SNOWLEOPARD', 'LEOPARD', 'XP', 'VISTA', 'WIN7', 'LUCID', 'APPLE_LEOPARD', 'APPLE_SNOWLEOPARD', 'APPLE_XP', 'APPLE_WIN7', 'GTK_LINUX', 'QT_LINUX'];
> +var PLATFORMS = ['LION', 'SNOWLEOPARD', 'LEOPARD', 'XP', 'VISTA', 'WIN7', 'LUCID', 'APPLE_LION', 'APPLE_LEOPARD', 'APPLE_SNOWLEOPARD', 'APPLE_XP', 'APPLE_WIN7', 'GTK_LINUX', 'QT_LINUX'];

What happens when this gets out of sync with the buildbot list of builders?

[Ojan Vafai]

Comment on attachment 134980 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134980&action=review

>> Tools/TestResultServer/static-dashboards/builders.js:157
>> +    if (xhr.readyState == 4) {
> 
> Why not just xhr.onload?

Cuz I'm old-school! lol...I didn't realize XHR had acquired an onload event. Changed this to use onload/onerror.

>> Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:319
>> +var PLATFORMS = ['LION', 'SNOWLEOPARD', 'LEOPARD', 'XP', 'VISTA', 'WIN7', 'LUCID', 'APPLE_LION', 'APPLE_LEOPARD', 'APPLE_SNOWLEOPARD', 'APPLE_XP', 'APPLE_WIN7', 'GTK_LINUX', 'QT_LINUX'];
> 
> What happens when this gets out of sync with the buildbot list of builders?

If there are extra values, nothing breaks. If a value is missing, then we throw a JS error and don't show any results for that bot.

[Ojan Vafai]

Committed r112807: <http://trac.webkit.org/changeset/112807>