Bug 82833

Summary: [GTK] Toggle buttons do not size appropriately in some themes
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Large toggles
none
Screenshot of the issue
none
Patch none

Description Martin Robinson 2012-03-31 10:02:58 PDT 
In some GTK+ themes, in particular Adwaita, toggle buttons that are larger than the default size do not render properly. See the attached HTML and screenshot.
Comment 1 Martin Robinson 2012-03-31 10:11:11 PDT 
Created attachment 134964 [details]
Large toggles
Comment 2 Martin Robinson 2012-03-31 10:37:36 PDT 
Created attachment 134966 [details]
Screenshot of the issue
Comment 3 Martin Robinson 2012-03-31 12:52:37 PDT 
Created attachment 134976 [details]
Patch
Comment 4 WebKit Review Bot 2012-03-31 12:58:02 PDT 
Attachment 134976 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
Source/WebCore/platform/gtk/RenderThemeGtk3.cpp:231:  Use 0 instead of NULL.  [readability/null] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 WebKit Review Bot 2012-04-09 11:56:44 PDT 
Comment on attachment 134976 [details]
Patch

Clearing flags on attachment: 134976

Committed r113601: <http://trac.webkit.org/changeset/113601>
Comment 6 WebKit Review Bot 2012-04-09 11:56:48 PDT 
All reviewed patches have been landed.  Closing bug.