Bug 82812

Summary: Web Inspector: [Mac] Using Open Link content menu item takes over the Web Inspector window
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web Inspector (Deprecated)Assignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Attachments:
Description Flags
Proposed Change
none
Proposed Change (Round 2) none

Timothy Hatcher
Reported 2012-03-30 18:13:23 PDT
1. Go to http://vimeo.com/21567634 2. Right click on the video, pick Inspect Element 3. Pull up the JS console 4. With the video element selected, evaluate $0.currentSrc 5. Right click on the URL and pick Open Link Expected: the video to open in the Safari tab Actual: the video opened in the Web Inspector window.
Attachments
Proposed Change (10.84 KB, patch)
2012-03-30 18:54 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Proposed Change (Round 2) (10.80 KB, patch)
2012-03-30 19:12 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2012-03-30 18:14:22 PDT
<rdar://problem/9488558>
Timothy Hatcher
Comment 2 2012-03-30 18:54:13 PDT
Created attachment 134927 [details] Proposed Change
WebKit Review Bot
Comment 3 2012-03-30 18:58:27 PDT
Attachment 134927 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/mac/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit2/UIProcess/WebInspectorProxy.cpp:33: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Timothy Hatcher
Comment 4 2012-03-30 19:12:12 PDT
Created attachment 134930 [details] Proposed Change (Round 2)
Timothy Hatcher
Comment 5 2012-03-30 19:12:39 PDT
Style fixed.
WebKit Review Bot
Comment 6 2012-03-31 18:18:26 PDT
Comment on attachment 134930 [details] Proposed Change (Round 2) Clearing flags on attachment: 134930 Committed r112808: <http://trac.webkit.org/changeset/112808>
WebKit Review Bot
Comment 7 2012-03-31 18:18:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.