Summary: | REGRESSION: Read only input text field renders at the wrong height when value attribute is not present | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Petersen <c.petersen87> | ||||
Component: | Forms | Assignee: | Adele Peterson <adele> | ||||
Status: | VERIFIED FIXED | ||||||
Severity: | Normal | CC: | bdakin, hyatt, mike | ||||
Priority: | P1 | Keywords: | InRadar, Regression | ||||
Version: | 420+ | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.4 | ||||||
URL: | http://www.alamo.com/ | ||||||
Attachments: |
|
Description
Chris Petersen
2006-04-08 18:47:18 PDT
Created attachment 7590 [details]
Input readonly test case
This issue was filed as <rdar://problem/4507668> bidi.cpp:1722 is where we set the special line height for contenteditable RenderBlocks. Adding code in bidi.cpp to check for a shadowParentNode will do the trick, but I'm not sure that's the right approach. It seems like the RenderTextField should have some default height. Maybe RenderTextField should have a layoutInlineChildren method? I'm confused why readonly breaks at all. How did you implement readonly? Did you make it turn off editability? I would not make readonly and disabled shut off editability. Because of the way disabled & readonly fields work on the mac, it makes sense to turn off editability. You can't place a caret in either of these cases. For readonly fields, you can make a selection, but we don't need the field to be editable to do that. Maciej suggested setting a height on the inner div. I've experimented with that, but I haven't gotten anything working well yet. Just setting a height on the div in createDivStyle messes up the baseline. I have built it, and I confirm that the issue seems to be solved. Thanks guys!! Verified with latest TOT Webkit build (r13990). |