Bug 82707

Summary:

[BlackBerry] Use KURL::protocolIsInHTTPFamily() instead KURL::protocolInHTTPFamily()

Product:

WebKit

Reporter:

Charles Wei <charles.wei>

Component:

WebKit BlackBerry

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

jasonliuwebkit, leo.yang, rwlbuis, staikos, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
use KURL::protocolIsInHTTPFamily() instead protocolInHTTPFamily()	rwlbuis: review+
Resubmit after fixing the comments from the reviewer.	webkit.review.bot: commit-queue-
Resubmit after filling in the reviewer info.	webkit.review.bot: commit-queue-
resubmit after fixing reviewer info.	none

Charles Wei

Reported 2012-03-30 02:28:23 PDT

KURL::protocolInHTTPFamily() is removed, should use KURL::protocolIsInHTTPFamily() instead, in Source/WebCore/platform/network/blackberry/NetworkManager.cpp.

Attachments
use KURL::protocolIsInHTTPFamily() instead protocolInHTTPFamily() (2.22 KB, patch) 2012-03-30 02:38 PDT, Charles Wei	rwlbuis: review+	Details Formatted Diff Diff
Resubmit after fixing the comments from the reviewer. (2.22 KB, patch) 2012-03-30 04:48 PDT, Charles Wei	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Resubmit after filling in the reviewer info. (2.22 KB, patch) 2012-03-30 05:10 PDT, Charles Wei	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
resubmit after fixing reviewer info. (2.21 KB, patch) 2012-03-30 18:57 PDT, Charles Wei	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Charles Wei

Comment 1 2012-03-30 02:31:02 PDT

Internal: 147117

Charles Wei

Comment 2 2012-03-30 02:38:25 PDT

Created attachment 134754 [details] use KURL::protocolIsInHTTPFamily() instead protocolInHTTPFamily()

Rob Buis

Comment 3 2012-03-30 04:26:22 PDT

Comment on attachment 134754 [details] use KURL::protocolIsInHTTPFamily() instead protocolInHTTPFamily() View in context: https://bugs.webkit.org/attachment.cgi?id=134754&action=review Looks good. > Source/WebCore/ChangeLog:8 > + No new tests,just BlackBerry build fix. Add a space after ','.

Charles Wei

Comment 4 2012-03-30 04:48:53 PDT

Created attachment 134778 [details] Resubmit after fixing the comments from the reviewer.

WebKit Review Bot

Comment 5 2012-03-30 04:57:16 PDT

Comment on attachment 134778 [details] Resubmit after fixing the comments from the reviewer. Rejecting attachment 134778 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/12266246

Charles Wei

Comment 6 2012-03-30 05:10:56 PDT

Created attachment 134787 [details] Resubmit after filling in the reviewer info.

WebKit Review Bot

Comment 7 2012-03-30 05:29:18 PDT

Comment on attachment 134787 [details] Resubmit after filling in the reviewer info. Rejecting attachment 134787 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/12247262

Charles Wei

Comment 8 2012-03-30 18:57:14 PDT

Created attachment 134929 [details] resubmit after fixing reviewer info.

WebKit Review Bot

Comment 9 2012-03-30 20:07:40 PDT

Comment on attachment 134929 [details] resubmit after fixing reviewer info. Clearing flags on attachment: 134929 Committed r112766: <http://trac.webkit.org/changeset/112766>

Charles Wei

Comment 10 2012-03-30 20:50:03 PDT

Resolved and patch landed.

Note You need to log in before you can comment on or make changes to this bug.