Bug 82687

Summary: Split up top-level .gitignore and .gitattributes
Product: WebKit Reporter: David Barr <davidbarr>
Component: WebKit Misc.Assignee: David Barr <davidbarr>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, gustavo, levin, mikelawther, mrobinson, tony, vestbo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://article.gmane.org/gmane.comp.version-control.git/194294
Attachments:
Description Flags
Patch
none
Patch none

Description David Barr 2012-03-29 21:29:01 PDT 
See this posting to the git mailing list:
http://article.gmane.org/gmane.comp.version-control.git/194294

tl;dr: Jeff King found that we can get a 1.6x speedup for 'git status' by splitting up .gitattributes and .gitignore.

Feedback welcome on Jeff's proposal.
Comment 1 David Barr 2012-03-29 22:20:37 PDT 
Created attachment 134724 [details]
Patch
Comment 2 David Barr 2012-03-29 22:30:22 PDT 
Potential variations are:
* Split into one patch per module
* Consolidate to one .gitignore and one .gitattributes file per module
Comment 3 Tor Arne Vestbø 2012-03-30 02:39:33 PDT 
Comment on attachment 134724 [details]
Patch

awesome
Comment 4 Tor Arne Vestbø 2012-03-30 02:43:12 PDT 
Comment on attachment 134724 [details]
Patch

Perhaps add a comment in the root ignore and attributes files (at the top) to use the leaf-files instead
Comment 5 David Barr 2012-03-30 07:25:52 PDT 
Created attachment 134808 [details]
Patch
Comment 6 WebKit Review Bot 2012-03-30 10:17:21 PDT 
Comment on attachment 134808 [details]
Patch

Clearing flags on attachment: 134808

Committed r112683: <http://trac.webkit.org/changeset/112683>
Comment 7 WebKit Review Bot 2012-03-30 10:17:27 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Tony Chang 2012-03-30 11:13:29 PDT 
Great find! Do we still need the .gitattributes entries? Shouldn't we just fix the svn:eol-style on the mentioned files and remove the -crlf .gitattributes entries?
Comment 9 David Barr 2012-03-31 22:10:32 PDT 
(In reply to comment #8)
> Great find! Do we still need the .gitattributes entries? Shouldn't we just fix the svn:eol-style on the mentioned files and remove the -crlf .gitattributes entries?

"Clean up LayoutTests/.gitattributes"
https://bugs.webkit.org/show_bug.cgi?id=82841