Bug 82687

Summary: Split up top-level .gitignore and .gitattributes
Product: WebKit Reporter: David Barr <davidbarr>
Component: WebKit Misc.Assignee: David Barr <davidbarr>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, gustavo, levin, mikelawther, mrobinson, tony, vestbo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://article.gmane.org/gmane.comp.version-control.git/194294
Attachments:
Description Flags
Patch
none
Patch none

David Barr
Reported 2012-03-29 21:29:01 PDT
See this posting to the git mailing list: http://article.gmane.org/gmane.comp.version-control.git/194294 tl;dr: Jeff King found that we can get a 1.6x speedup for 'git status' by splitting up .gitattributes and .gitignore. Feedback welcome on Jeff's proposal.
Attachments
Patch (71.84 KB, patch)
2012-03-29 22:20 PDT, David Barr 		no flags
DetailsFormatted DiffDiff
Patch (42.27 KB, patch)
2012-03-30 07:25 PDT, David Barr 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Barr
Comment 1 2012-03-29 22:20:37 PDT
Created attachment 134724 [details] Patch
David Barr
Comment 2 2012-03-29 22:30:22 PDT
Potential variations are: * Split into one patch per module * Consolidate to one .gitignore and one .gitattributes file per module
Tor Arne Vestbø
Comment 3 2012-03-30 02:39:33 PDT
Comment on attachment 134724 [details] Patch awesome
Tor Arne Vestbø
Comment 4 2012-03-30 02:43:12 PDT
Comment on attachment 134724 [details] Patch Perhaps add a comment in the root ignore and attributes files (at the top) to use the leaf-files instead
David Barr
Comment 5 2012-03-30 07:25:52 PDT
Created attachment 134808 [details] Patch
WebKit Review Bot
Comment 6 2012-03-30 10:17:21 PDT
Comment on attachment 134808 [details] Patch Clearing flags on attachment: 134808 Committed r112683: <http://trac.webkit.org/changeset/112683>
WebKit Review Bot
Comment 7 2012-03-30 10:17:27 PDT
All reviewed patches have been landed. Closing bug.
Tony Chang
Comment 8 2012-03-30 11:13:29 PDT
Great find! Do we still need the .gitattributes entries? Shouldn't we just fix the svn:eol-style on the mentioned files and remove the -crlf .gitattributes entries?
David Barr
Comment 9 2012-03-31 22:10:32 PDT
(In reply to comment #8) > Great find! Do we still need the .gitattributes entries? Shouldn't we just fix the svn:eol-style on the mentioned files and remove the -crlf .gitattributes entries? "Clean up LayoutTests/.gitattributes" https://bugs.webkit.org/show_bug.cgi?id=82841
Note You need to log in before you can comment on or make changes to this bug.