Bug 8268

Summary: REGRESSION (r13639): Caret leaves a small footprint in the focus ring as it moves
Product: WebKit Reporter: Justin Garcia <justin.garcia>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: alice.barraclough, darin, ddkilzer, hyatt, ian, koivisto
Priority: P1 Keywords: HasReduction, InRadar, Regression
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
testcase none

Justin Garcia
Reported 2006-04-08 15:46:03 PDT
Attaching a testcase
Attachments
testcase (205 bytes, text/html)
2006-04-08 15:47 PDT, Justin Garcia 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Justin Garcia
Comment 1 2006-04-08 15:47:01 PDT
Created attachment 7586 [details] testcase
Darin Adler
Comment 2 2006-04-08 17:04:27 PDT
Dave, this is what I was worried about re-introducing. I guess it happened!
Dave Hyatt
Comment 3 2006-04-10 11:10:58 PDT
I have a good way of fixing this that will handle overflow too (the old fix for this didn't).
Dave Hyatt
Comment 4 2006-04-10 13:38:40 PDT
The last outline-related checkin before revision 13639 is the one darin made to deal with textfield focus rings not matching. My code had not yet landed, so this is not related to my coalesced update changes.
Darin Adler
Comment 5 2006-04-11 09:25:54 PDT
I've verified that the focus-ring drawing functions are called when the caret blinks, but nothing is being drawn. Continuing to investigate.
Darin Adler
Comment 6 2006-04-11 09:41:34 PDT
There's some kind of rounding problem here. Setting an outline-offset of either 1px or -1px makes the bug go away.
Alice Liu
Comment 7 2006-05-21 22:33:09 PDT
<rdar://problem/4556558>
Darin Adler
Comment 8 2007-01-29 09:09:08 PST
Waiting on a Core Graphics fix for focus ring drawing before revisiting this problem.
Antti Koivisto
Comment 9 2007-02-18 13:47:28 PST
It seems that if the clip overlaps inside edge of the focus ring exactly one pixel deep the focus ring does not get drawn. This particular bug can be easily worked around in repaintRectForCaret (in SelectionController.cpp) by doing caret.inflate(2) instead of inflate(1) or removing the inflate line. First option increases overlap and makes the focus ring paint correctly, second one removes overlap. That just hides the actual problem though. I think this is most likely the same problem as bug 11965.
David Kilzer (:ddkilzer)
Comment 10 2007-12-05 08:44:51 PST
I can still reproduce this bug with the attached test case (Attachment #7586 [details]), but not with this test case: data:text/html,<input type=text>
David Kilzer (:ddkilzer)
Comment 11 2007-12-05 08:45:27 PST
(In reply to comment #10) > I can still reproduce this bug with the attached test case (Attachment #7586 [details] [edit]), > but not with this test case: > > data:text/html,<input type=text> Using a local debug build of WebKit r28434 with Safari 3.0.4 (523.12) on Mac OS X 10.4.11 (8S165).
mitz
Comment 12 2007-12-07 11:26:35 PST
Fixed in <http://trac.webkit.org/projects/webkit/changeset/28523>.
Note You need to log in before you can comment on or make changes to this bug.