Summary: | IndexedDB: Race condition causes version change transaction to commit after onblocked | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joshua Bell <jsbell> | ||||||||||
Component: | New Bugs | Assignee: | Joshua Bell <jsbell> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | dgrogan, tony, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | 82776 | ||||||||||||
Bug Blocks: | |||||||||||||
Attachments: |
|
Description
Joshua Bell
2012-03-29 17:10:23 PDT
Created attachment 134700 [details]
Patch
Attachment 134700 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:13: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 134700 [details]
Patch
Prematurely optimized - shouldn't look at m_readyState == DONE since cursor.continue() would reset the ready state. Need to explicitly test for blocked event.
Created attachment 134852 [details]
Patch
Comment on attachment 134852 [details]
Patch
Attached test verifies the patch in Chromium. The test fails in DRT - the worker is being treated as a different origin?
Created attachment 134872 [details]
Patch
Tracked down the DRT issue - http://webkit.org/b/82776 - nontrivial, unfortunately, so landing the test marked FAIL for now and will run it under Chromium's browser test system. tony@, can you take a look? Comment on attachment 134872 [details]
Patch
I think you need to commit an -expected.txt file otherwise the test will show up as MISSING.
Created attachment 134892 [details]
Patch for landing
Comment on attachment 134892 [details] Patch for landing Clearing flags on attachment: 134892 Committed r112740: <http://trac.webkit.org/changeset/112740> All reviewed patches have been landed. Closing bug. |