| Summary: | [Chromium] Move ResourceHandle to WebCore/platform/network/chromium | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
| Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | jamesr, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Adam Barth
2012-03-29 14:19:54 PDT
Created attachment 134665 [details]
Patch
Attachment 134665 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/network/chromium/ResourceHandle.cpp:247: One space before end of line comments [whitespace/comments] [5]
Source/WebCore/platform/network/chromium/ResourceHandle.cpp:279: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebCore/platform/network/chromium/ResourceHandle.cpp:283: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Total errors found: 3 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 134665 [details]
Patch
Cool!
Committed r112579: <http://trac.webkit.org/changeset/112579> Reverted r112579 for reason: Does not compile in Windows component build Committed r112633: <http://trac.webkit.org/changeset/112633> |