Bug 82582

Summary: Move CPP files related to ResourceHandle to WebCore/platform
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch jamesr: review+

Description Adam Barth 2012-03-29 01:18:21 PDT
Move CPP files related to ResourceHandle to WebCore/platform
Comment 1 Adam Barth 2012-03-29 01:23:25 PDT
Created attachment 134523 [details]
Patch
Comment 2 James Robinson 2012-03-29 10:37:17 PDT
Doesn't apply, does this patch depend on some other patch?
Comment 3 Adam Barth 2012-03-29 10:40:45 PDT
I don't think it does.  Maybe there was a conflict in one of the GYP files.  I'll makes sure it applies and builds before landing it.
Comment 4 Adam Barth 2012-03-29 10:42:04 PDT
Actually, I think it's a bug in svn-apply related to moving and modifying files at the same time.
Comment 5 James Robinson 2012-03-29 10:46:58 PDT
That is frustrating! Which patch is this over in github?
Comment 6 James Robinson 2012-03-29 10:56:17 PDT
Comment on attachment 134523 [details]
Patch

Looks good. Guessing you probably don't wanna try to land by commit queue :)
Comment 7 Adam Barth 2012-03-29 11:47:53 PDT
> That is frustrating! Which patch is this over in github?

I'm sorry if this is frustrating.  I can cross-link them better.  This one is https://github.com/abarth/webkit/commit/68d9044a8fd46a1533eb6f0d82138764371d0c1d

If you look at this list <https://github.com/abarth/webkit/compare/master...webcore-platform>, the bug titles should line up with the commit names.

Note: These patches aren't identical to the ones in GitHub.  For example, I've figured out a better way to handle WrappedResourceRequest (at least until the last step).
Comment 8 Adam Barth 2012-03-29 13:52:54 PDT
Committed r112572: <http://trac.webkit.org/changeset/112572>
Comment 9 Adam Barth 2012-03-29 18:37:19 PDT
Reverted r112572 for reason:

Does not compile in Windows component build

Committed r112634: <http://trac.webkit.org/changeset/112634>
Comment 10 Adam Barth 2012-03-30 15:23:31 PDT
Committed r112731: <http://trac.webkit.org/changeset/112731>