Bug 82551

Summary: [Chromium] IndexedDB: Enable compression of leveldb blocks
Product: WebKit Reporter: Joshua Bell <jsbell>
Component: WebKit Misc.Assignee: Joshua Bell <jsbell>
Status: RESOLVED INVALID    
Severity: Normal CC: cc-bugs, epenner, jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Joshua Bell
Reported 2012-03-28 16:47:27 PDT
Once snappy support has landed in Chromium http://crbug.com/81384 then we can enable opening LevelDB instances with kSnappyCompression: diff --git a/Source/WebCore/platform/leveldb/LevelDBDatabase.cpp b/Source/WebCore/platform/leveldb/LevelDBDatabase.cpp index 273afd4..4ef384e 100644 --- a/Source/WebCore/platform/leveldb/LevelDBDatabase.cpp +++ b/Source/WebCore/platform/leveldb/LevelDBDatabase.cpp @@ -108,6 +108,7 @@ static leveldb::Status openDB(leveldb::Comparator* comparator, leveldb::Env* env options.create_if_missing = true; options.paranoid_checks = true; options.env = env; + options.compression = leveldb::kSnappyCompression; return leveldb::DB::Open(options, path.utf8().data(), db); }
Attachments
Patch (1.38 KB, patch)
2012-03-28 16:49 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Patch (74.36 KB, patch)
2012-08-16 00:15 PDT, Eric Penner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Joshua Bell
Comment 1 2012-03-28 16:49:02 PDT
Created attachment 134445 [details] Patch
Joshua Bell
Comment 2 2012-04-02 14:13:46 PDT
Not necessary; the leveldb::Options constructor enables kSnappyCompression by default.
Eric Penner
Comment 3 2012-08-16 00:15:33 PDT
Reopening to attach new patch.
Eric Penner
Comment 4 2012-08-16 00:15:34 PDT
Created attachment 158728 [details] Patch
Eric Penner
Comment 5 2012-08-16 00:28:31 PDT
Apologies. I mistyped 82251
Note You need to log in before you can comment on or make changes to this bug.