Bug 82539 – Delete dispatchDidLoadMainResource callback

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Nate Chapin]

No port implements it, let's get rid of it.

[Nate Chapin]

Created attachment 134423 [details]
patch

[Alexey Proskuryakov]

Comment on attachment 134423 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134423&action=review

> Source/WebKit/mac/WebKit.order:-772
> -__ZN20WebFrameLoaderClient27dispatchDidLoadMainResourceEPN7WebCore14DocumentLoaderE

It's OK to modify this file, but no need to do that.

[Nate Chapin]

(In reply to comment #2)
> (From update of attachment 134423 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=134423&action=review
> 
> > Source/WebKit/mac/WebKit.order:-772
> > -__ZN20WebFrameLoaderClient27dispatchDidLoadMainResourceEPN7WebCore14DocumentLoaderE
> 
> It's OK to modify this file, but no need to do that.

I'll keep that in mind for the future. I just deleted every occurence of "dispatchDidLoadMainResource" that wasn't in a ChangeLog :)

[WebKit Review Bot]

Comment on attachment 134423 [details]
patch

Rejecting attachment 134423 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
reSupport/WebFrameLoaderClient.h.rej
patching file Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
Hunk #1 FAILED at 753.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp.rej
patching file Source/WebKit2/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Alexey Pro..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12194002

[WebKit Review Bot]

Comment on attachment 134423 [details]
patch

Clearing flags on attachment: 134423

Committed r112474: <http://trac.webkit.org/changeset/112474>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.