Summary: | minidom configurations should be based on ToolExecutable.xcconfig | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||
Component: | JavaScriptCore | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | fpizlo, ggaren, mitz, mrowe, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Attachment 134380 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 134380 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134380&action=review > Source/JavaScriptCore/Configurations/ToolExecutable.xcconfig:29 > +INSTALL_PATH = $(INSTALL_PATH_$(TARGET_NAME)); > +INSTALL_PATH_JSCLLIntOffsetsExtractor = $(JAVASCRIPTCORE_RESOURCES_DIR); > +INSTALL_PATH_minidom = /usr/local/bin; > +INSTALL_PATH_testapi = $(JAVASCRIPTCORE_RESOURCES_DIR); > +INSTALL_PATH_testRegExp = $(JAVASCRIPTCORE_RESOURCES_DIR); This seems unnecessary. There's no good reason for minidom to be put in /usr/local/bin when everything else is going in to JavaScriptCore.framework/Resources. Created attachment 134446 [details]
Patch
(In reply to comment #2) > (From update of attachment 134380 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=134380&action=review > > > Source/JavaScriptCore/Configurations/ToolExecutable.xcconfig:29 > > +INSTALL_PATH = $(INSTALL_PATH_$(TARGET_NAME)); > > +INSTALL_PATH_JSCLLIntOffsetsExtractor = $(JAVASCRIPTCORE_RESOURCES_DIR); > > +INSTALL_PATH_minidom = /usr/local/bin; > > +INSTALL_PATH_testapi = $(JAVASCRIPTCORE_RESOURCES_DIR); > > +INSTALL_PATH_testRegExp = $(JAVASCRIPTCORE_RESOURCES_DIR); > > This seems unnecessary. There's no good reason for minidom to be put in /usr/local/bin when everything else is going in to JavaScriptCore.framework/Resources. Fixed in second patch. (I kept the semi-colon, though!) Committed r112496: <http://trac.webkit.org/changeset/112496> |
Created attachment 134380 [details] Patch Reviewed by NOBODY (OOPS!). * Configurations/ToolExecutable.xcconfig: Extract JAVASCRIPTCORE_RESOURCES_DIR into its own variable. Define INSTALL_PATH based on TARGET_NAME. * JavaScriptCore.xcodeproj/project.pbxproj: Base minidom configurations on ToolExecutable.xcconfig. Remove redundant PRODUCT_NAME and SKIP_INSTALL variables. --- 3 files changed, 23 insertions(+), 9 deletions(-)