Bug 82473 – [GTK] Tools/Scripts/run-gtk-tests should not force you to use the WebKit jhbuild

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

We have Tools/gtk/run-with-jhbuild, so that whatever it needs to run with jhbuild can use that script.

[Philippe Normand]

Can it by default use the wrapper unless some --no-jhbuild option is passed?

[Carlos Garcia Campos]

Created attachment 134311 [details]
Patch

This way people not using jhbuild can use run-gtk-tests too, and we don't need a special case for when run-gtk-tests is executed by make check.

[Carlos Garcia Campos]

(In reply to comment #1)
> Can it by default use the wrapper unless some --no-jhbuild option is passed?

I don't think we need another command line option for this

[Philippe Normand]

(In reply to comment #3)
> (In reply to comment #1)
> > Can it by default use the wrapper unless some --no-jhbuild option is passed?
> 
> I don't think we need another command line option for this

This won't work on the bots, I'm afraid.

[Carlos Garcia Campos]

(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #1)
> > > Can it by default use the wrapper unless some --no-jhbuild option is passed?
> > 
> > I don't think we need another command line option for this
> 
> This won't work on the bots, I'm afraid.

why? I updated the bot config to use run-with-jhbuild

[Philippe Normand]

(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > (In reply to comment #1)
> > > > Can it by default use the wrapper unless some --no-jhbuild option is passed?
> > > 
> > > I don't think we need another command line option for this
> > 
> > This won't work on the bots, I'm afraid.
> 
> why? I updated the bot config to use run-with-jhbuild

Right, I missed that!
Anyway, we discussed some time ago about being smart and detect if WebKitBuild/Dependencies are there and in that case run in jhbuild by default. Maybe we could start doing that?

[Carlos Garcia Campos]

(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > (In reply to comment #3)
> > > > (In reply to comment #1)
> > > > > Can it by default use the wrapper unless some --no-jhbuild option is passed?
> > > > 
> > > > I don't think we need another command line option for this
> > > 
> > > This won't work on the bots, I'm afraid.
> > 
> > why? I updated the bot config to use run-with-jhbuild
> 
> Right, I missed that!
> Anyway, we discussed some time ago about being smart and detect if WebKitBuild/Dependencies are there and in that case run in jhbuild by default. Maybe we could start doing that?

why running every command inside run-gtk-test with jhbuild when you can tun the whole script?

[Carlos Garcia Campos]

Btw, I think we should so the same for build-webkit

[Martin Robinson]

Comment on attachment 134311 [details]
Patch

I don't really understand this patch. Do you mind explaining it a bit better? It seems like it will make it more inconvenient for people using the WebKit jhbuild. The script already has the logic to avoid running jhbuild when it isn't there. What does it buy us?

[Martin Robinson]

After talking with Carlos, it seems any solution that doesn't force him to use the WebKit jhbuild is okay. Instead of making it more inconvenient to use the WebKit jhbuild, it should just be possible to avoid using it. I think the tools can be smart enough to make the decision automatically. I'll upload a new patch shortly.

[Martin Robinson]

Created attachment 134355 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 134355 [details]
Patch

Yeah, I think this is enough for me, thanks!

[Philippe Normand]

Comment on attachment 134355 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134355&action=review

Can you fix the floowing little nit before landing?

> Tools/ChangeLog:8
> +        Only use jhbuild if WebKitBuild/Dependencies (if update-

This seems to be truncated

[Martin Robinson]

Committed r113066: <http://trac.webkit.org/changeset/113066>