Bug 82466 – Use xcrun to find nm and ranlib on OS X builds

• Component: Tools / Tests
• Status: RESOLVED FIXED

[David Kilzer (:ddkilzer)]

When running build-webkit, we should use xcrun to find the nm(1) and ranlib(1) commands on OS X.

[David Kilzer (:ddkilzer)]

Created attachment 134292 [details]
Patch

Comment on attachment 134292 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134292&action=review

> Tools/Scripts/webkitperl/features.pm:57
> +sub nmPath()
> +{
> +    if (isAppleMacWebKit()) {
> +        my $nm = `xcrun -find nm`;
> +        chomp $nm;
> +        return $nm if $nm;
> +    }
> +    return "nm";
> +}

Should this function cache the result? Probably doesn’t matter if we run nm only on libraries, but could matter if we run it on every new .o file.

[David Kilzer (:ddkilzer)]

Created attachment 134330 [details]
Patch

[David Kilzer (:ddkilzer)]

(In reply to comment #3)
> Created an attachment (id=134330) [details]
> Patch

ChangeLog:
- Moved nmPath() to webkitdirs.pm so check-for-global-initializers could use it later.
- Cache result of nmPath().
- Moved $ranlib out of the foreach loop in build-webkit.

Comment on attachment 134330 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134330&action=review

> Tools/Scripts/webkitdirs.pm:1312
> +sub determineNMPath()

I don’t know why the M is uppercase :-)

[David Kilzer (:ddkilzer)]

(In reply to comment #5)
> (From update of attachment 134330 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=134330&action=review
> 
> > Tools/Scripts/webkitdirs.pm:1312
> > +sub determineNMPath()
> 
> I don’t know why the M is uppercase :-)

My Shift key was stuck?!  :)  Fixed.

[David Kilzer (:ddkilzer)]

Committed r112431: <http://trac.webkit.org/changeset/112431>