Bug 82456

Summary: [EFL] Icon database path may be NULL when a new path was set
Product: WebKit Reporter: Grzegorz Czajkowski <g.czajkowski>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, leandro, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Attachments:
Description Flags
proposed patch
none
rebased patch none

Grzegorz Czajkowski
Reported 2012-03-28 06:00:30 PDT
ewk_settings_icon_database_path_set calls asynchronous method WebCore::iconDatabase().open(). There is no notification when the new path is set by WebCore. Moreover ewk_settings_icon_database_path_set keeps the new path in a local variable. To retrieve path to icon database ewk_settings_icon_database_path_get can be called. It first checks flags whether icon databse is opened and enabled. There is possibility that icon database has been set through API but it hasn't been opened by WebCore yet. So as a result ewk_settings_icon_database_path_get returns NULL because WebCore hasn't set an appropriate flag yet. It may happen while icon database set/get sequences. Information whether icon database is opened/enabled should be exposed by separate API.
Attachments
proposed patch (2.65 KB, patch)
2012-03-28 06:02 PDT, Grzegorz Czajkowski 		no flags
DetailsFormatted DiffDiff
rebased patch (2.64 KB, patch)
2012-03-28 06:32 PDT, Grzegorz Czajkowski 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Grzegorz Czajkowski
Comment 1 2012-03-28 06:02:05 PDT
Created attachment 134275 [details] proposed patch skip checking whether icon database is opened and enabled to get icon database path
Grzegorz Czajkowski
Comment 2 2012-03-28 06:32:44 PDT
Created attachment 134282 [details] rebased patch
Grzegorz Czajkowski
Comment 3 2012-04-16 06:59:05 PDT
Hi Lucas, Could you review this patch? I think those checks are no longer needed. WebKit-Gtk doesn't check them when the data base path is being gotten.
Andreas Kling
Comment 4 2012-05-07 05:07:37 PDT
Comment on attachment 134282 [details] rebased patch Certainly looks more correct this way. r=me
WebKit Review Bot
Comment 5 2012-05-07 05:29:27 PDT
Comment on attachment 134282 [details] rebased patch Clearing flags on attachment: 134282 Committed r116302: <http://trac.webkit.org/changeset/116302>
WebKit Review Bot
Comment 6 2012-05-07 05:29:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.