Summary: | Leak in WebCore::SVGFontElement::create | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kenichi Ishibashi <bashi> | ||||
Component: | SVG | Assignee: | Kenichi Ishibashi <bashi> | ||||
Status: | RESOLVED DUPLICATE | ||||||
Severity: | Normal | CC: | jschuh, macpherson, menard, thorton, webkit.review.bot, zimmermann | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
URL: | http://crbug.com/120453 | ||||||
Attachments: |
|
Description
Kenichi Ishibashi
2012-03-28 03:39:41 PDT
Created attachment 134254 [details]
Patch
Comment on attachment 134254 [details]
Patch
I think they were added on purpose - don't you see any crashes now?? Maybe something has changed, but I'd be careful here.
Can you try running tests under guard malloc? nrwt --tolerance 0 -p svg -g, and/or with --gc-between-tests.
(In reply to comment #2) > (From update of attachment 134254 [details]) > I think they were added on purpose - don't you see any crashes now?? Maybe something has changed, but I'd be careful here. I didn't see any crashes with this patch, but I agree that we should be careful. I'd like to hear jschuh's opinion. > Can you try running tests under guard malloc? nrwt --tolerance 0 -p svg -g, and/or with --gc-between-tests. All svg tests ran as expected with above switches (Debug/Release). (In reply to comment #0) > See the stacktrace at http://crbug.com/120453. I don't see one. No, it's not safe to remove the RefPtr without making other changes. This is discussed in bug 66438, along with an explanation of the solution to the memory leak. I just haven't had a chance to do any WebKit work in the last few months. *** This bug has been marked as a duplicate of bug 66438 *** Comment on attachment 134254 [details]
Patch
Thanks. Removing r?.
|