|Summary:||[GTK] Initial cookies API for WebKit2 GTK+ API|
|Product:||WebKit||Reporter:||Carlos Garcia Campos <firstname.lastname@example.org>|
|Severity:||Normal||CC:||email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org|
|Version:||528+ (Nightly build)|
|Bug Depends on:|
Add an initial WebKitCookieManager object to be able to set the acceptance policy, get domains and delete cookies.
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
(From update of attachment 134247 [details]) View in context: https://bugs.webkit.org/attachment.cgi?id=134247&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitCookieManager.cpp:210 > + WKCookieManagerDeleteCookiesForHostname(manager->priv->wkCookieManager.get(), wkDomain.get()); Are the delete calls synchronous, or do we just not care about the result in this case? Also what about deleting a single cookie? That's something Ephy does today, something we want to keep supporting?
(In reply to comment #3) > (From update of attachment 134247 [details] [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=134247&action=review Thanks for reviewing! > > Source/WebKit2/UIProcess/API/gtk/WebKitCookieManager.cpp:210 > > + WKCookieManagerDeleteCookiesForHostname(manager->priv->wkCookieManager.get(), wkDomain.get()); > > Are the delete calls synchronous, or do we just not care about the result in this case? It's async, but the C API doesn't provide any result nor callback to be emitted when the operation finishes. > Also what about deleting a single cookie? Not supported by the C API. > That's something Ephy does today, something we want to keep supporting? As I commented in the mailing list when I proposed this API, it's not a common operation, people usually remove the cookies for a domain rather than a single cookie. However, since bugs #82081 and #82082 landed already, it's now possible to see the details of all cookies using the inspector, as well as deleting a single cookie. So, we could leave that as an advanced feature available through the inspector. Or we can add the API if you think it's really important. In any case, I think it would be batter to discuss about it in the mailing list, see this thread: https://lists.webkit.org/pipermail/webkit-gtk/2012-March/001007.html
Committed r113870: <http://trac.webkit.org/changeset/113870>