Bug 82438

Summary: [EFL] Change ewk_settings_icon_database_icon_object_add to proper API name
Product: WebKit Reporter: Grzegorz Czajkowski <g.czajkowski>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Attachments:
Description Flags
proposed patch
none
updated patch according to Kubo's review none

Description Grzegorz Czajkowski 2012-03-28 01:59:39 PDT 
It's one of problematic issues - changing API.

The purpose of ewk_settings_icon_database_icon_object_add is to get icon for the given URL.
This function doesn't add anything to database. Documentation and API name has been adjusted.
Comment 1 Grzegorz Czajkowski 2012-03-28 02:02:02 PDT 
Created attachment 134239 [details]
proposed patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-03-31 18:48:33 PDT 
Comment on attachment 134239 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134239&action=review

Makes sense, thanks.

> Source/WebKit/efl/ewk/ewk_settings.h:187
> + * @note "load,finished" singal doesn't guarantee that icons are completely loaded and

Typo: "singal". Using "the" before the signal names (ie. 'The "foo,bar" signal) looks better as well, both here and in the next line.
Comment 3 Grzegorz Czajkowski 2012-04-03 03:36:27 PDT 
Created attachment 135301 [details]
updated patch according to Kubo's review

Kubo, Could you look again at this patch?
Comment 4 Raphael Kubo da Costa (:rakuco) 2012-04-03 04:51:12 PDT 
Comment on attachment 135301 [details]
updated patch according to Kubo's review

Looks good, thanks.
Comment 5 Gyuyoung Kim 2012-04-04 02:01:12 PDT 
Comment on attachment 135301 [details]
updated patch according to Kubo's review

Looks good to me too.
Comment 6 WebKit Review Bot 2012-04-04 05:24:48 PDT 
Comment on attachment 135301 [details]
updated patch according to Kubo's review

Clearing flags on attachment: 135301

Committed r113173: <http://trac.webkit.org/changeset/113173>
Comment 7 WebKit Review Bot 2012-04-04 05:24:52 PDT 
All reviewed patches have been landed.  Closing bug.