Summary: | transforms/no_transform_hit_testing.html is flaky | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dirk Pranke <dpranke> | ||||||
Component: | Tools / Tests | Assignee: | Florin Malita <fmalita> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | fmalita, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Dirk Pranke
2012-03-27 18:52:28 PDT
Since this test doesn't seems to need pixel-level checks, it should be converted to use dumpAsText() and avoid the current flaky font rendering issues. Created attachment 135141 [details]
Patch
Attachment 135141 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
ERROR: File does not exist: 'LayoutTests/platform/mac/transforms/no_transform_hit_testing-expected.png'
If any of these errors are false positives, please file a bug against check-webkit-style.
The style error is a check-webkit-style bug. Filed https://bugs.webkit.org/show_bug.cgi?id=82933. Comment on attachment 135141 [details] Patch Rejecting attachment 135141 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: _hit_testing-expected.png' patching file LayoutTests/platform/qt/transforms/no_transform_hit_testing-expected.txt rm 'LayoutTests/platform/qt/transforms/no_transform_hit_testing-expected.txt' patching file LayoutTests/transforms/no_transform_hit_testing-expected.txt patching file LayoutTests/transforms/no_transform_hit_testing.html Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Simon Fras..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12442324 Created attachment 137998 [details]
Patch for landing
Comment on attachment 137998 [details] Patch for landing Clearing flags on attachment: 137998 Committed r114693: <http://trac.webkit.org/changeset/114693> All reviewed patches have been landed. Closing bug. |