Bug 82415

Summary:

transforms/no_transform_hit_testing.html is flaky

Product:

WebKit

Reporter:

Dirk Pranke <dpranke>

Component:

Tools / Tests

Assignee:

Florin Malita <fmalita>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

fmalita, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Dirk Pranke

Reported 2012-03-27 18:52:28 PDT

It looks like it usually clears up on a retry, though http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=transforms%2Fno_transform_hit_testing.html

Attachments
Patch (157.45 KB, patch) 2012-04-02 11:43 PDT, Florin Malita	no flags	Details Formatted Diff Diff
Patch for landing (157.53 KB, patch) 2012-04-19 16:18 PDT, Florin Malita	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Florin Malita

Comment 1 2012-04-02 11:32:43 PDT

Since this test doesn't seems to need pixel-level checks, it should be converted to use dumpAsText() and avoid the current flaky font rendering issues.

Florin Malita

Comment 2 2012-04-02 11:43:41 PDT

Created attachment 135141 [details] Patch

WebKit Review Bot

Comment 3 2012-04-02 11:47:04 PDT

Attachment 135141 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 ERROR: File does not exist: 'LayoutTests/platform/mac/transforms/no_transform_hit_testing-expected.png' If any of these errors are false positives, please file a bug against check-webkit-style.

Florin Malita

Comment 4 2012-04-02 13:38:30 PDT

The style error is a check-webkit-style bug. Filed https://bugs.webkit.org/show_bug.cgi?id=82933.

WebKit Review Bot

Comment 5 2012-04-19 14:25:09 PDT

Comment on attachment 135141 [details] Patch Rejecting attachment 135141 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: _hit_testing-expected.png' patching file LayoutTests/platform/qt/transforms/no_transform_hit_testing-expected.txt rm 'LayoutTests/platform/qt/transforms/no_transform_hit_testing-expected.txt' patching file LayoutTests/transforms/no_transform_hit_testing-expected.txt patching file LayoutTests/transforms/no_transform_hit_testing.html Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Simon Fras..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12442324

Florin Malita

Comment 6 2012-04-19 16:18:29 PDT

Created attachment 137998 [details] Patch for landing

WebKit Review Bot

Comment 7 2012-04-19 16:46:39 PDT

Comment on attachment 137998 [details] Patch for landing Clearing flags on attachment: 137998 Committed r114693: <http://trac.webkit.org/changeset/114693>

WebKit Review Bot

Comment 8 2012-04-19 16:46:44 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.