Bug 82393

Summary: Add assertions to valueForLength() and RenderBox::computeLogicalWidthInRegionUsing() to help with debugging.
Product: WebKit Reporter: Luke Macpherson <macpherson>
Component: New BugsAssignee: Luke Macpherson <macpherson>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, macpherson, menard, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Luke Macpherson
Reported 2012-03-27 16:26:06 PDT
Add assertions to valueForLength() and RenderBox::computeLogicalWidthInRegionUsing() to help with debugging.
Attachments
Patch (2.35 KB, patch)
2012-03-27 16:27 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.36 KB, patch)
2012-03-27 16:35 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Luke Macpherson
Comment 1 2012-03-27 16:27:13 PDT
Created attachment 134160 [details] Patch
WebKit Review Bot
Comment 2 2012-03-27 16:29:27 PDT
Attachment 134160 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Seidel (no email)
Comment 3 2012-03-27 16:30:59 PDT
Comment on attachment 134160 [details] Patch OK. rs=me. Obviously the fix the style-bot's complaints.
Luke Macpherson
Comment 4 2012-03-27 16:35:16 PDT
Created attachment 134164 [details] Patch for landing
Alexis Menard (darktears)
Comment 5 2012-03-27 16:36:53 PDT
Comment on attachment 134164 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=134164&action=review > Source/WebCore/css/LengthFunctions.cpp:83 > + // multiple assertions are used below to provide more useful debug output. This should start with upper-case.
WebKit Review Bot
Comment 6 2012-03-27 17:12:46 PDT
Comment on attachment 134164 [details] Patch for landing Clearing flags on attachment: 134164 Committed r112336: <http://trac.webkit.org/changeset/112336>
WebKit Review Bot
Comment 7 2012-03-27 17:12:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.