Bug 82384 – Separate @import rules from other rules in CSSStyleSheet

• Component: CSS
• Status: RESOLVED FIXED

[Antti Koivisto]

Import rules always come before all other rules (except @charset). They currently live in the generic child rule vector. They can be moved to a vector of their own for stronger typing and more focused traversal. This will also make future refactoring easier.

[Antti Koivisto]

Created attachment 134145 [details]
patch

[WebKit Review Bot]

Attachment 134145 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/css/CSSStyleSheet.cpp:347:  Missing space before {  [whitespace/braces] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alexis Menard (darktears)]

Comment on attachment 134145 [details]
patch

Looks good to me. You need to fix the style issue (or as kling would say : "where you derped")

[WebKit Review Bot]

Comment on attachment 134145 [details]
patch

Attachment 134145 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12143810

New failing tests:
fast/dom/css-cached-import-rule.html
fast/css/import-and-insert-rule-no-update.html
fast/dom/css-insert-import-rule.html

[WebKit Review Bot]

Created attachment 134159 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Andreas Kling]

(In reply to comment #4)
> (From update of attachment 134145 [details])
> Attachment 134145 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/12143810
> 
> New failing tests:
> fast/dom/css-cached-import-rule.html
> fast/css/import-and-insert-rule-no-update.html
> fast/dom/css-insert-import-rule.html

I trusted you, man :'(

[Alexis Menard (darktears)]

(In reply to comment #6)
> (In reply to comment #4)
> > (From update of attachment 134145 [details] [details])
> > Attachment 134145 [details] [details] did not pass chromium-ews (chromium-xvfb):
> > Output: http://queues.webkit.org/results/12143810
> > 
> > New failing tests:
> > fast/dom/css-cached-import-rule.html
> > fast/css/import-and-insert-rule-no-update.html
> > fast/dom/css-insert-import-rule.html
> 
> I trusted you, man :'(

Ouuchhhhh </3

[Antti Koivisto]

http://trac.webkit.org/changeset/112382

Turned out that that removing explicit styleSheetChanged() call for @import insertions causes problems so I kept that for now with a FIXME.