Summary: | webkit_unit_tests crashing on chromium lion in ScrollbarLayerChromiumTest.resolveScrollLayerPointer | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dirk Pranke <dpranke> | ||||
Component: | Tools / Tests | Assignee: | James Robinson <jamesr> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | trchen, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Dirk Pranke
2012-03-27 14:42:39 PDT
The stack doesn't make complete sense to me yet, but the bug is that we're calling in to ScrollbarThemeMac's scrollbar registration during this test which tries to access something and then explodes (possibly the Scrollbar's m_scrollableArea, which we have set to NULL?). It's very dodgy to be calling a virtual function during a classes constructor. This only blows up on Lion since that's the only platform where we have overlay scrollbars on by default. We actually should probably just enable the mock scrollbar theme for this unit test. I'll try to repro locally and try this out. Created attachment 134186 [details]
Patch
Comment on attachment 134186 [details]
Patch
Oh, nice thought to use the mock scrollbars in the unit test. R=me.
Comment on attachment 134186 [details] Patch Clearing flags on attachment: 134186 Committed r112351: <http://trac.webkit.org/changeset/112351> All reviewed patches have been landed. Closing bug. |