Bug 82350

Summary: [BlackBerry] Switch WebPageCompositor to use AnimationFrameRateController instead of timer
Product: WebKit Reporter: Andrew Lo <anlo>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Andrew Lo
Reported 2012-03-27 09:47:44 PDT
WebPageCompositor currently uses a timer to drive accelerated CSS animations. Have it use AnimationFrameRateController instead.
Attachments
Patch (4.75 KB, patch)
2012-03-27 10:16 PDT, Andrew Lo 		no flags
DetailsFormatted DiffDiff
Patch (4.72 KB, patch)
2012-03-27 10:38 PDT, Andrew Lo 		no flags
DetailsFormatted DiffDiff
Patch (4.71 KB, patch)
2012-03-27 10:43 PDT, Andrew Lo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andrew Lo
Comment 1 2012-03-27 10:16:01 PDT
Created attachment 134092 [details] Patch
Rob Buis
Comment 2 2012-03-27 10:22:15 PDT
Comment on attachment 134092 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134092&action=review Looks good, some prefixes can be stripped. > Source/WebKit/blackberry/Api/WebPageCompositor.cpp:53 > + BlackBerry::Platform::AnimationFrameRateController::instance()->removeClient(this); No BlackBerry prefix needed. > Source/WebKit/blackberry/Api/WebPageCompositor.cpp:130 > + BlackBerry::Platform::AnimationFrameRateController::instance()->addClient(this); Ditto. > Source/WebKit/blackberry/Api/WebPageCompositor_p.h:44 > +class WebPageCompositorPrivate : public RefCounted<WebPageCompositorPrivate>, public BlackBerry::Platform::AnimationFrameRateClient { Ditto.
Andrew Lo
Comment 3 2012-03-27 10:38:03 PDT
Created attachment 134099 [details] Patch
Andrew Lo
Comment 4 2012-03-27 10:43:34 PDT
Created attachment 134100 [details] Patch
Rob Buis
Comment 5 2012-03-27 10:47:32 PDT
Comment on attachment 134100 [details] Patch Perfect!
WebKit Review Bot
Comment 6 2012-03-27 11:40:17 PDT
Comment on attachment 134100 [details] Patch Clearing flags on attachment: 134100 Committed r112287: <http://trac.webkit.org/changeset/112287>
WebKit Review Bot
Comment 7 2012-03-27 11:40:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.