Bug 82350

Summary: [BlackBerry] Switch WebPageCompositor to use AnimationFrameRateController instead of timer
Product: WebKit Reporter: Andrew Lo <anlo>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Andrew Lo 2012-03-27 09:47:44 PDT 
WebPageCompositor currently uses a timer to drive accelerated CSS animations. Have it use AnimationFrameRateController instead.
Comment 1 Andrew Lo 2012-03-27 10:16:01 PDT 
Created attachment 134092 [details]
Patch
Comment 2 Rob Buis 2012-03-27 10:22:15 PDT 
Comment on attachment 134092 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134092&action=review

Looks good, some prefixes can be stripped.

> Source/WebKit/blackberry/Api/WebPageCompositor.cpp:53
> +    BlackBerry::Platform::AnimationFrameRateController::instance()->removeClient(this);

No BlackBerry prefix needed.

> Source/WebKit/blackberry/Api/WebPageCompositor.cpp:130
> +            BlackBerry::Platform::AnimationFrameRateController::instance()->addClient(this);

Ditto.

> Source/WebKit/blackberry/Api/WebPageCompositor_p.h:44
> +class WebPageCompositorPrivate : public RefCounted<WebPageCompositorPrivate>, public BlackBerry::Platform::AnimationFrameRateClient {

Ditto.
Comment 3 Andrew Lo 2012-03-27 10:38:03 PDT 
Created attachment 134099 [details]
Patch
Comment 4 Andrew Lo 2012-03-27 10:43:34 PDT 
Created attachment 134100 [details]
Patch
Comment 5 Rob Buis 2012-03-27 10:47:32 PDT 
Comment on attachment 134100 [details]
Patch

Perfect!
Comment 6 WebKit Review Bot 2012-03-27 11:40:17 PDT 
Comment on attachment 134100 [details]
Patch

Clearing flags on attachment: 134100

Committed r112287: <http://trac.webkit.org/changeset/112287>
Comment 7 WebKit Review Bot 2012-03-27 11:40:21 PDT 
All reviewed patches have been landed.  Closing bug.