Bug 82324

Summary:

Should not draw selection for empty spaces.

Product:

WebKit

Reporter:

Parag Radke <parag>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

UNCONFIRMED

Severity:

Normal

CC:

ap, parag, rniwa, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

URL:

http://www.webkit.org/

Attachments:

Description	Flags
snapshot for select all on webkit.org	none
Proposed Patch	tony: review-, tony: commit-queue-
text selection in TextEdit	none
comparison of Firefox and Webkit selection (with this change).	none

Parag Radke

Reported 2012-03-27 04:58:58 PDT

Created attachment 134029 [details] snapshot for select all on webkit.org See the attached images. go to http://www.webkit.org/ do select all Webkit selects the empty spaces along with the selectable content. webkit should instead draw selection background only for selectable content.

Attachments
snapshot for select all on webkit.org (216.35 KB, image/png) 2012-03-27 04:58 PDT, Parag Radke	no flags	Details
Proposed Patch (26.06 KB, patch) 2012-03-27 05:36 PDT, Parag Radke	tony: review- tony: commit-queue-	Details Formatted Diff Diff
text selection in TextEdit (37.98 KB, image/png) 2012-03-27 10:18 PDT, Tony Chang	no flags	Details
comparison of Firefox and Webkit selection (with this change). (302.12 KB, image/jpeg) 2012-03-28 02:09 PDT, Parag Radke	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Parag Radke

Comment 1 2012-03-27 05:36:55 PDT

Created attachment 134037 [details] Proposed Patch Patch to avoid selection draw for empty spaces.

Tony Chang

Comment 2 2012-03-27 10:18:40 PDT

Created attachment 134093 [details] text selection in TextEdit

Tony Chang

Comment 3 2012-03-27 10:20:20 PDT

Comment on attachment 134037 [details] Proposed Patch This is incorrect on Mac. On Mac, the selection is always a rectangle and lines extend to the edge of the page. We may want different behavior on Linux/Win which has the jagged selection you describe.

Ryosuke Niwa

Comment 4 2012-03-27 10:24:04 PDT

If we're doing this, we probably also want to set the height of selection to the height of actual text instead of the entire line height to follow the Windows convention.

Ryosuke Niwa

Comment 5 2012-03-27 10:26:03 PDT

Of course, that could be done in a follow up patch.

Tony Chang

Comment 6 2012-03-27 11:02:07 PDT

I also just tried this in gedit, and it produced a Mac like selection. notepad.exe on Windows had a selection similar to the one in "Proposed Patch".

Parag Radke

Comment 7 2012-03-28 02:00:05 PDT

(In reply to comment #6) > I also just tried this in gedit, and it produced a Mac like selection. notepad.exe on Windows had a selection similar to the one in "Proposed Patch". Yes tony you are correct the gedit selection behavior is similar to the chrome behavior on Linux. But what i was trying to match is not platform but firefox. But if webkit want to go with the default platform behavior i'll restrict this change to windows

Parag Radke

Comment 8 2012-03-28 02:09:07 PDT

Created attachment 134240 [details] comparison of Firefox and Webkit selection (with this change).

Ryosuke Niwa

Comment 9 2012-03-28 02:13:23 PDT

(In reply to comment #7) > Yes tony you are correct the gedit selection behavior is similar to the chrome behavior on Linux. But what i was trying to match is not platform but firefox. But if webkit want to go with the default platform behavior i'll restrict this change to windows We normally match platform convention.

Alexey Proskuryakov

Comment 10 2012-03-28 09:22:22 PDT

Rectangular selections are a must on Mac, and perhaps for Apple Windows products too. I'm not sure who'd be willing to make the call about the latter.

Parag Radke

Comment 11 2012-03-28 12:32:22 PDT

(In reply to comment #10) > Rectangular selections are a must on Mac, and perhaps for Apple Windows products too. I'm not sure who'd be willing to make the call about the latter. So this change should exclude Apple windows products? And is there any way to achieve this ?

Ryosuke Niwa

Comment 12 2012-03-28 12:38:49 PDT

This bug belongs to layout and rendering.

Note You need to log in before you can comment on or make changes to this bug.