Bug 82321

Summary: Add a perf test which updates the value of an already declared CSS property.
Product: WebKit Reporter: Alexis Menard (darktears) <menard>
Component: New BugsAssignee: Alexis Menard (darktears) <menard>
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch for landing none

Description Alexis Menard (darktears) 2012-03-27 04:43:17 PDT
Add a perf test when updating the value of an already declared CSS property.
Comment 1 Alexis Menard (darktears) 2012-03-27 04:45:14 PDT
Created attachment 134025 [details]
Comment 2 Andreas Kling 2012-03-27 04:48:43 PDT
Comment on attachment 134025 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=134025&action=review


> PerformanceTests/CSS/CSSPropertyUpdateValue.html:77
> +PerfTestRunner.run(function() {
> +    for (key in properties)
> +        div.style[key] = properties[key];
> +}, 10000);

Would be nice with a comment noting that the first pass is discarded from the results, since otherwise it looks like one of the passes will add, not update, properties.
Comment 3 Alexis Menard (darktears) 2012-03-27 04:50:27 PDT
Created attachment 134026 [details]
Patch for landing
Comment 4 Alexis Menard (darktears) 2012-03-27 04:57:12 PDT
Comment on attachment 134026 [details]
Patch for landing

Clearing flags on attachment: 134026

Committed r112253: <http://trac.webkit.org/changeset/112253>
Comment 5 Alexis Menard (darktears) 2012-03-27 04:57:28 PDT
All reviewed patches have been landed.  Closing bug.